-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(walker): use std::ranges:sort instead of std::sort #1267
Conversation
Signed-off-by: Tony Gorez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: cb14653 | Previous: b61df71 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
3753.186686434589 ns/iter |
4228.983833536213 ns/iter |
0.89 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
770.7382108467192 ns/iter |
756.8970007657384 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Required_Properties |
949.9642256027854 ns/iter |
944.3472298982031 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
153.52649616177553 ns/iter |
163.10640559463337 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
104.5416786961451 ns/iter |
110.2332090922805 ns/iter |
0.95 |
JSONSchema_Validate_Draft4_Items_Schema |
2830.943283201709 ns/iter |
2997.754831915101 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Nested_Object |
1366.2450712153247 ns/iter |
1425.7948252337903 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1462.9787968838727 ns/iter |
1407.773732902339 ns/iter |
1.04 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1065.1869096869739 ns/iter |
1127.4141609006783 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1806.5700825153197 ns/iter |
1447.88217283138 ns/iter |
1.25 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
216.85763067302778 ns/iter |
199.9800586967782 ns/iter |
1.08 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
1417.3307026477255 ns/iter |
1422.2993634325308 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
115.66890554262612 ns/iter |
118.82817779364315 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
373.05078222528664 ns/iter |
431.2833290797157 ns/iter |
0.86 |
JSONSchema_Validate_Draft4_Nested_Oneof |
375.92046849126297 ns/iter |
388.48040997733597 ns/iter |
0.97 |
JSONSchema_Validate_Draft6_Property_Names |
803.4214736147877 ns/iter |
798.4428659732785 ns/iter |
1.01 |
JSONSchema_Validate_Draft7_If_Then_Else |
181.43439780859384 ns/iter |
175.58734697807049 ns/iter |
1.03 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
3276850624.999952 ns/iter |
3289723541.9999332 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: cb14653 | Previous: b61df71 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
2153.4494395008314 ns/iter |
2125.466187203498 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
974.9465110969314 ns/iter |
969.8297490641231 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Required_Properties |
1542.920712309329 ns/iter |
1550.6650848154436 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
179.7152227621727 ns/iter |
178.66687902311585 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
127.70003678397129 ns/iter |
127.76845643075254 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Items_Schema |
3941.9872128754305 ns/iter |
4021.3208777623354 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Nested_Object |
1590.3314072878013 ns/iter |
1623.690513745676 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1811.081113519454 ns/iter |
1830.8155239609716 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1485.6333573436264 ns/iter |
1522.9760682388805 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1909.3204403005018 ns/iter |
1918.1837939895374 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
475.3981752915778 ns/iter |
484.9073095400828 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
2441.5414027760557 ns/iter |
2485.7303650443373 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
126.94045918174048 ns/iter |
130.3317448280249 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
589.0305808003562 ns/iter |
607.4604941581644 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Nested_Oneof |
474.1294168032295 ns/iter |
501.29739099998005 ns/iter |
0.95 |
JSONSchema_Validate_Draft6_Property_Names |
1203.3374968869557 ns/iter |
1266.1937730728878 ns/iter |
0.95 |
JSONSchema_Validate_Draft7_If_Then_Else |
210.31577180105475 ns/iter |
216.23716011899097 ns/iter |
0.97 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
5440405645.999931 ns/iter |
5718458451.999936 ns/iter |
0.95 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: cb14653 | Previous: b61df71 | Ratio |
---|---|---|---|
JSONSchema_Compiler_Draft6_AdaptiveCard |
6279936421.000002 ns/iter |
6337498589.000006 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1091.9450961275813 ns/iter |
1071.00218471577 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Required_Properties |
2285.7817701530485 ns/iter |
2213.849232737453 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
194.79069169016623 ns/iter |
189.939282994826 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
138.5768686754944 ns/iter |
133.7014831079329 ns/iter |
1.04 |
JSONSchema_Validate_Draft4_Items_Schema |
3297.835706719754 ns/iter |
3323.038183948757 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Nested_Object |
1787.1951374093255 ns/iter |
1728.2659043137805 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1689.4316202839373 ns/iter |
1664.5526159290514 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1356.0051205403963 ns/iter |
1350.834848610817 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1767.9087771126804 ns/iter |
1752.186969079661 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
464.5757318521186 ns/iter |
468.0941453933242 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
2310.3742674332398 ns/iter |
2260.2885569095783 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
142.52331129193112 ns/iter |
143.19506605534158 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
1090.2704708797198 ns/iter |
1109.9155069693222 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Nested_Oneof |
454.92708842327323 ns/iter |
429.05788632978897 ns/iter |
1.06 |
JSONSchema_Validate_Draft6_Property_Names |
1605.0459400349303 ns/iter |
1653.3827042390626 ns/iter |
0.97 |
JSONSchema_Validate_Draft7_If_Then_Else |
204.62147306684307 ns/iter |
203.44449435695464 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
3224.475043173324 ns/iter |
3192.926992207455 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: cb14653 | Previous: b61df71 | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
5031.629999999723 ns/iter |
5175.542857142342 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2237.1611192401137 ns/iter |
2275.7921874998033 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Required_Properties |
1902.6354047268928 ns/iter |
2082.5222349577925 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
550.2850000000186 ns/iter |
549.6886000000814 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
400.53169642855534 ns/iter |
405.59359796460564 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Items_Schema |
6307.054464284891 ns/iter |
6346.158035714415 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Nested_Object |
3824.577991825446 ns/iter |
3838.726180846141 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
5282.4919642852865 ns/iter |
5329.37899999979 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
4345.176249999839 ns/iter |
4358.736250000561 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
5376.552999999831 ns/iter |
5437.367999999196 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
562.7017857142797 ns/iter |
559.1048214285925 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
7882.195312500784 ns/iter |
7977.271083610246 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
404.84691049789853 ns/iter |
413.17045741501 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
794.1879464286674 ns/iter |
798.640759535353 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Nested_Oneof |
1055.5553125000117 ns/iter |
1066.4462499999418 ns/iter |
0.99 |
JSONSchema_Validate_Draft6_Property_Names |
1821.4559120143736 ns/iter |
1847.3172743905548 ns/iter |
0.99 |
JSONSchema_Validate_Draft7_If_Then_Else |
554.8574999999848 ns/iter |
566.4353571427837 ns/iter |
0.98 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
10307690999.999977 ns/iter |
11459921900.00004 ns/iter |
0.90 |
This comment was automatically generated by workflow using github-action-benchmark.
Clang tidy recommandation