-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always unroll properties
under oneOf
#1268
Conversation
Signed-off-by: Juan Cruz Viotti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: 4b59135 | Previous: 5ceffcc | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
3554.47044372934 ns/iter |
3784.8978662231107 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
741.4742861164857 ns/iter |
798.8841480558408 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Required_Properties |
955.071936893088 ns/iter |
1015.6660752904231 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
156.02742174408726 ns/iter |
161.79997970870286 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
104.17813997396765 ns/iter |
112.3691521948755 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Items_Schema |
2650.755275467811 ns/iter |
2818.090088091676 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Nested_Object |
1354.4536790528664 ns/iter |
1441.3055751119657 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1370.1683233630015 ns/iter |
1500.132463669815 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1035.4013907828275 ns/iter |
1121.4930756209956 ns/iter |
0.92 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1381.6197881904484 ns/iter |
1485.3545476358092 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
196.12567832511604 ns/iter |
208.26287991411326 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
1369.5894182661393 ns/iter |
1463.0809322059686 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
106.16705537838324 ns/iter |
115.67794671711938 ns/iter |
0.92 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
353.4882728310404 ns/iter |
378.59047267176106 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Nested_Oneof |
364.237325288742 ns/iter |
389.84884271118574 ns/iter |
0.93 |
JSONSchema_Validate_Draft6_Property_Names |
774.4458103992765 ns/iter |
824.0157211933015 ns/iter |
0.94 |
JSONSchema_Validate_Draft7_If_Then_Else |
170.72219372438926 ns/iter |
180.61002675001055 ns/iter |
0.95 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
2997076416.9999027 ns/iter |
3342542166.000044 ns/iter |
0.90 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: 4b59135 | Previous: 5ceffcc | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
2235.2512604552676 ns/iter |
2102.8682742975384 ns/iter |
1.06 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1031.519672540254 ns/iter |
1036.620636559516 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
1647.7844409666625 ns/iter |
1669.2732172160615 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
185.5564724363225 ns/iter |
186.8406769637506 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
129.8945901513615 ns/iter |
133.1222628404555 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Items_Schema |
4284.126728408122 ns/iter |
4289.51846217136 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Object |
1696.948965450481 ns/iter |
1739.19234938634 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1820.7759081479933 ns/iter |
1835.6381803921238 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1499.2664255116765 ns/iter |
1532.6239369146244 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1966.5085442023412 ns/iter |
1920.9372444179876 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
484.19491861681803 ns/iter |
486.2986283149758 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
2574.3918458803596 ns/iter |
2558.4363684810396 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
133.1106033910757 ns/iter |
135.7339554324512 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
602.7418352589667 ns/iter |
605.6757889058457 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Oneof |
534.9030990620632 ns/iter |
537.5680509982101 ns/iter |
1.00 |
JSONSchema_Validate_Draft6_Property_Names |
1312.6586535569584 ns/iter |
1312.5223155077078 ns/iter |
1.00 |
JSONSchema_Validate_Draft7_If_Then_Else |
229.3504433392009 ns/iter |
231.22807340615944 ns/iter |
0.99 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
5695456648.999993 ns/iter |
5673500844.000046 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: 4b59135 | Previous: 5ceffcc | Ratio |
---|---|---|---|
JSONSchema_Compiler_Draft6_AdaptiveCard |
6333264050.000025 ns/iter |
6410052627.000028 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1055.15045129814 ns/iter |
1059.0876412458883 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
2290.463268764626 ns/iter |
2368.5063835362707 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
188.7836468754898 ns/iter |
190.48707913190503 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
142.07933938310092 ns/iter |
138.9728414495219 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Items_Schema |
3200.922083975375 ns/iter |
3062.40769395784 ns/iter |
1.05 |
JSONSchema_Validate_Draft4_Nested_Object |
1745.3658867161041 ns/iter |
1727.9609674477003 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1677.5860902147017 ns/iter |
1667.5505133436793 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1380.9379506583011 ns/iter |
1364.7976551895158 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1762.9908842092107 ns/iter |
1751.708448345078 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
479.9765950052814 ns/iter |
480.813844012553 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
2358.166025130048 ns/iter |
2335.4275254419463 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
149.08058485529494 ns/iter |
143.7310665749886 ns/iter |
1.04 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
1115.7224866944064 ns/iter |
1151.345635421773 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Nested_Oneof |
453.309452116333 ns/iter |
430.5515434301001 ns/iter |
1.05 |
JSONSchema_Validate_Draft6_Property_Names |
1634.2469196950162 ns/iter |
1621.6906341211466 ns/iter |
1.01 |
JSONSchema_Validate_Draft7_If_Then_Else |
196.53958789797093 ns/iter |
197.02103190509737 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
3433.834148368889 ns/iter |
3192.577458775558 ns/iter |
1.08 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: 4b59135 | Previous: 5ceffcc | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
5133.409999998548 ns/iter |
5240.476999999828 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2304.338276408323 ns/iter |
2338.3346670372407 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Required_Properties |
2008.4378219164216 ns/iter |
2022.3498686937967 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
539.8947321428491 ns/iter |
539.5201785713003 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
412.5324015119898 ns/iter |
412.2105976690715 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Items_Schema |
6494.8535714311865 ns/iter |
6471.800892857767 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Object |
3858.6517857146823 ns/iter |
3940.3934151785843 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
5263.224999997159 ns/iter |
5405.448999999861 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
4327.789374997337 ns/iter |
4449.199588305518 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
5355.183035719944 ns/iter |
5485.45357143025 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
551.3766999993095 ns/iter |
557.5144000001728 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
7892.354910714923 ns/iter |
8083.485491073057 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
415.78165108145737 ns/iter |
410.81234326723455 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
764.0440848218434 ns/iter |
773.9575892859054 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Nested_Oneof |
1086.688906249833 ns/iter |
1087.4649999998098 ns/iter |
1.00 |
JSONSchema_Validate_Draft6_Property_Names |
1823.4806459654897 ns/iter |
1849.1700439018157 ns/iter |
0.99 |
JSONSchema_Validate_Draft7_If_Then_Else |
561.7651785712496 ns/iter |
548.7993750000848 ns/iter |
1.02 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
10272721600.000296 ns/iter |
10380249499.99999 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti [email protected]