-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only apply type bounds optimizations on FastValidation
mode
#1280
Conversation
Signed-off-by: Juan Cruz Viotti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: b3e0df1 | Previous: 37aff6f | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
3552.6587594816656 ns/iter |
4783.578877227337 ns/iter |
0.74 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
753.1862510985417 ns/iter |
925.2822699975223 ns/iter |
0.81 |
JSONSchema_Validate_Draft4_Required_Properties |
946.8098316650804 ns/iter |
1034.7158184268337 ns/iter |
0.92 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
152.1655372336924 ns/iter |
165.21926272485166 ns/iter |
0.92 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
104.58140332611764 ns/iter |
111.96255678071621 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Items_Schema |
2644.1696175384645 ns/iter |
3114.72661587016 ns/iter |
0.85 |
JSONSchema_Validate_Draft4_Nested_Object |
22.825915141593047 ns/iter |
25.068596771055155 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1288.0569246629 ns/iter |
1999.316521895905 ns/iter |
0.64 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
953.8927020659489 ns/iter |
1405.5608246835068 ns/iter |
0.68 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1307.1273574685542 ns/iter |
1463.0862907775188 ns/iter |
0.89 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
215.12982203659408 ns/iter |
231.34435339610073 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
1353.8773070348059 ns/iter |
1487.1378834159893 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
105.11497270599313 ns/iter |
115.15384919791448 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
407.1506880410135 ns/iter |
541.949449338809 ns/iter |
0.75 |
JSONSchema_Validate_Draft4_Nested_Oneof |
367.8039833452496 ns/iter |
457.25810138375846 ns/iter |
0.80 |
JSONSchema_Validate_Draft6_Property_Names |
777.4330030081655 ns/iter |
1079.2418627134848 ns/iter |
0.72 |
JSONSchema_Validate_Draft7_If_Then_Else |
168.68158036023166 ns/iter |
208.17015817112323 ns/iter |
0.81 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
2876126666.9998803 ns/iter |
3579290708.0000305 ns/iter |
0.80 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: b3e0df1 | Previous: 37aff6f | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
2086.185917963969 ns/iter |
2174.985408046147 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
973.1962255040052 ns/iter |
977.4513869037038 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
1606.3248992337046 ns/iter |
1550.5428167037169 ns/iter |
1.04 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
181.4379531040748 ns/iter |
180.53857074311838 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
130.59161318145382 ns/iter |
128.79651600542286 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Items_Schema |
3498.419691350162 ns/iter |
3489.733631887188 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Object |
33.349876503406435 ns/iter |
33.4368700655597 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1816.5574125107948 ns/iter |
1782.26120768523 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1475.074284004321 ns/iter |
1485.9218420138002 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1862.8156462077081 ns/iter |
1883.8885984928488 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
481.9818849478001 ns/iter |
481.5418599320939 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
2419.000079657051 ns/iter |
2447.594610993615 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
132.16397969987918 ns/iter |
132.0714280042046 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
598.1920868384902 ns/iter |
599.0656722803168 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Oneof |
474.45300091126825 ns/iter |
472.2450434111126 ns/iter |
1.00 |
JSONSchema_Validate_Draft6_Property_Names |
1242.1980440991506 ns/iter |
1226.8275637836662 ns/iter |
1.01 |
JSONSchema_Validate_Draft7_If_Then_Else |
208.5779903580134 ns/iter |
209.68793416543483 ns/iter |
0.99 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
5693688503.999965 ns/iter |
5483468854.000023 ns/iter |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: b3e0df1 | Previous: 37aff6f | Ratio |
---|---|---|---|
JSONSchema_Compiler_Draft6_AdaptiveCard |
6264690637.000058 ns/iter |
6102685909.999991 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1074.2401994026716 ns/iter |
1065.4603791484517 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Required_Properties |
2226.922197277993 ns/iter |
2241.519664105006 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
185.38562964188506 ns/iter |
186.8751048294911 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
136.2404535996072 ns/iter |
132.99983007624684 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Items_Schema |
3011.332383738762 ns/iter |
2999.2824093086397 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Object |
22.369929203937428 ns/iter |
24.021828934570998 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1880.0986738471615 ns/iter |
1759.5718155656675 ns/iter |
1.07 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1545.4089950931464 ns/iter |
1442.1280331315686 ns/iter |
1.07 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1967.6940325618568 ns/iter |
1851.2428725673444 ns/iter |
1.06 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
453.6887449203642 ns/iter |
461.26461474018566 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
2485.474199411447 ns/iter |
2363.420447805156 ns/iter |
1.05 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
144.63948387049317 ns/iter |
140.30373469008543 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
1075.2365138805292 ns/iter |
1080.2937232871002 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Oneof |
422.57824790981516 ns/iter |
425.0937193771304 ns/iter |
0.99 |
JSONSchema_Validate_Draft6_Property_Names |
1567.4472537400509 ns/iter |
1555.8833485225211 ns/iter |
1.01 |
JSONSchema_Validate_Draft7_If_Then_Else |
194.53984952446567 ns/iter |
193.47477997376217 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
3208.0363666912294 ns/iter |
3211.57328972226 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: b3e0df1 | Previous: 37aff6f | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
4972.700892857063 ns/iter |
5265.401999999995 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2327.270505278449 ns/iter |
2393.770989095413 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Required_Properties |
1993.0595011825112 ns/iter |
2023.0065435341899 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
552.0718749999836 ns/iter |
556.4482142856622 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
410.15102633252513 ns/iter |
408.268928202329 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Items_Schema |
6343.320535713863 ns/iter |
6485.616071427407 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Nested_Object |
161.2863169642915 ns/iter |
160.41886160712082 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
5419.460000000527 ns/iter |
5441.794999999274 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
4405.729999999864 ns/iter |
4441.994375000036 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
5524.955000000772 ns/iter |
5485.782142855554 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
534.2764285714452 ns/iter |
534.0078999997786 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
8048.89508928573 ns/iter |
8020.671782713101 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
416.88771915656855 ns/iter |
416.13310519938176 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
745.4449107143546 ns/iter |
735.8639508928836 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Nested_Oneof |
1090.5871874999918 ns/iter |
1109.7532812499367 ns/iter |
0.98 |
JSONSchema_Validate_Draft6_Property_Names |
1815.3651030044787 ns/iter |
1865.3130047440675 ns/iter |
0.97 |
JSONSchema_Validate_Draft7_If_Then_Else |
562.2365178571239 ns/iter |
557.8491999999642 ns/iter |
1.01 |
JSONSchema_Compiler_Draft6_AdaptiveCard |
10006925999.999908 ns/iter |
10214839699.999857 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti [email protected]