Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propertly detect presence of unevaluated* keywords #1286

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 11, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti force-pushed the detect-unevaluated branch 7 times, most recently from 65d696d to 9ee3e16 Compare October 11, 2024 15:30
@jviotti jviotti marked this pull request as ready for review October 11, 2024 15:31
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 5802926 Previous: 47edec0 Ratio
JSON_Array_Of_Objects_Unique 3547.397463559005 ns/iter 3886.68849282841 ns/iter 0.91
JSONSchema_Validate_Draft4_Meta_1_No_Callback 733.2802460247051 ns/iter 822.8170469146477 ns/iter 0.89
JSONSchema_Validate_Draft4_Required_Properties 953.5681649005921 ns/iter 1041.308364321238 ns/iter 0.92
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 173.79458614245416 ns/iter 170.0530255973037 ns/iter 1.02
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 104.284930063754 ns/iter 116.9128075411056 ns/iter 0.89
JSONSchema_Validate_Draft4_Items_Schema 2647.6247376137226 ns/iter 2894.929416221768 ns/iter 0.91
JSONSchema_Validate_Draft4_Nested_Object 22.708368428880615 ns/iter 24.604984093884188 ns/iter 0.92
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1244.8087949939575 ns/iter 1386.5480430408404 ns/iter 0.90
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1008.3991392954389 ns/iter 1117.6894357611327 ns/iter 0.90
JSONSchema_Validate_Draft4_Properties_Triad_Required 1281.151417771136 ns/iter 1545.9689324795622 ns/iter 0.83
JSONSchema_Validate_Draft4_Non_Recursive_Ref 213.5828041081729 ns/iter 231.93492320044308 ns/iter 0.92
JSONSchema_Validate_Draft4_Pattern_Properties_True 1332.9634990306686 ns/iter 1501.527606507495 ns/iter 0.89
JSONSchema_Validate_Draft4_Ref_To_Single_Property 104.82963680102834 ns/iter 120.2630662701897 ns/iter 0.87
JSONSchema_Validate_Draft4_Additional_Properties_Type 435.0571089753349 ns/iter 535.8577079999804 ns/iter 0.81
JSONSchema_Validate_Draft4_Nested_Oneof 398.9990061618073 ns/iter 389.03322159552744 ns/iter 1.03
JSONSchema_Validate_Draft6_Property_Names 779.6889541672683 ns/iter 882.9773184778253 ns/iter 0.88
JSONSchema_Validate_Draft7_If_Then_Else 170.30657208202942 ns/iter 179.66522678072695 ns/iter 0.95
JSONSchema_Compiler_Draft6_AdaptiveCard 2914179832.9999347 ns/iter 3241009749.999989 ns/iter 0.90

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 5802926 Previous: 47edec0 Ratio
JSON_Array_Of_Objects_Unique 2111.437971340189 ns/iter 2113.328638128594 ns/iter 1.00
JSONSchema_Validate_Draft4_Meta_1_No_Callback 959.2454864958679 ns/iter 1024.0604276641184 ns/iter 0.94
JSONSchema_Validate_Draft4_Required_Properties 1579.059794898775 ns/iter 1603.6627109395008 ns/iter 0.98
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 181.83437726446107 ns/iter 180.96881592437913 ns/iter 1.00
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 130.1052142839216 ns/iter 130.28620326188562 ns/iter 1.00
JSONSchema_Validate_Draft4_Items_Schema 3575.228256867466 ns/iter 3640.693648288703 ns/iter 0.98
JSONSchema_Validate_Draft4_Nested_Object 33.42784134293528 ns/iter 32.46772004720749 ns/iter 1.03
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1806.5113435503124 ns/iter 1816.1448587632337 ns/iter 0.99
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1492.4807733228088 ns/iter 1499.677035818621 ns/iter 1.00
JSONSchema_Validate_Draft4_Properties_Triad_Required 1867.3385732978722 ns/iter 1895.024806506937 ns/iter 0.99
JSONSchema_Validate_Draft4_Non_Recursive_Ref 483.3299041704276 ns/iter 481.65934967794766 ns/iter 1.00
JSONSchema_Validate_Draft4_Pattern_Properties_True 2422.636858214996 ns/iter 2431.1528671331066 ns/iter 1.00
JSONSchema_Validate_Draft4_Ref_To_Single_Property 133.3003719786804 ns/iter 133.95679811078188 ns/iter 1.00
JSONSchema_Validate_Draft4_Additional_Properties_Type 600.7171370483245 ns/iter 601.7655572030578 ns/iter 1.00
JSONSchema_Validate_Draft4_Nested_Oneof 472.5446795670897 ns/iter 473.6924520961653 ns/iter 1.00
JSONSchema_Validate_Draft6_Property_Names 1243.7491754094426 ns/iter 1244.5978290579721 ns/iter 1.00
JSONSchema_Validate_Draft7_If_Then_Else 208.59214221292476 ns/iter 209.67776786519102 ns/iter 0.99
JSONSchema_Compiler_Draft6_AdaptiveCard 5510823795.999954 ns/iter 5509634097.999992 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 5802926 Previous: 47edec0 Ratio
JSONSchema_Compiler_Draft6_AdaptiveCard 6359531545.999971 ns/iter 6359412871.000018 ns/iter 1.00
JSONSchema_Validate_Draft4_Meta_1_No_Callback 1061.150110549509 ns/iter 1108.5612964604843 ns/iter 0.96
JSONSchema_Validate_Draft4_Required_Properties 2276.9290537030097 ns/iter 2258.146274130973 ns/iter 1.01
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 192.9266004505889 ns/iter 202.09757876269302 ns/iter 0.95
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 135.61091605408365 ns/iter 135.00307763239954 ns/iter 1.00
JSONSchema_Validate_Draft4_Items_Schema 3011.9277116739663 ns/iter 3058.841925587918 ns/iter 0.98
JSONSchema_Validate_Draft4_Nested_Object 22.77199186288032 ns/iter 23.39944917653415 ns/iter 0.97
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1704.07463361678 ns/iter 1701.2308821104275 ns/iter 1.00
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1398.0552594451808 ns/iter 1409.5475724063867 ns/iter 0.99
JSONSchema_Validate_Draft4_Properties_Triad_Required 1796.395043128675 ns/iter 1787.2286822888425 ns/iter 1.01
JSONSchema_Validate_Draft4_Non_Recursive_Ref 457.5826021148345 ns/iter 469.1834295108136 ns/iter 0.98
JSONSchema_Validate_Draft4_Pattern_Properties_True 2310.1029079361106 ns/iter 2359.8942385852656 ns/iter 0.98
JSONSchema_Validate_Draft4_Ref_To_Single_Property 143.549843723925 ns/iter 140.2758742001748 ns/iter 1.02
JSONSchema_Validate_Draft4_Additional_Properties_Type 1081.317844256309 ns/iter 1106.3950055552448 ns/iter 0.98
JSONSchema_Validate_Draft4_Nested_Oneof 428.3300955053617 ns/iter 437.79995986720104 ns/iter 0.98
JSONSchema_Validate_Draft6_Property_Names 1596.404380532565 ns/iter 1628.2246609229162 ns/iter 0.98
JSONSchema_Validate_Draft7_If_Then_Else 201.76850636737484 ns/iter 209.4442784280615 ns/iter 0.96
JSON_Array_Of_Objects_Unique 3219.9727373501532 ns/iter 3194.079484185953 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 5802926 Previous: 47edec0 Ratio
JSON_Array_Of_Objects_Unique 4993.8380000003235 ns/iter 5132.069999999658 ns/iter 0.97
JSONSchema_Validate_Draft4_Meta_1_No_Callback 2291.544062499895 ns/iter 2352.0239285712055 ns/iter 0.97
JSONSchema_Validate_Draft4_Required_Properties 1975.1321206537461 ns/iter 2017.456001624733 ns/iter 0.98
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 549.8449999998505 ns/iter 575.3916071429087 ns/iter 0.96
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 399.8902343750491 ns/iter 412.20363338375165 ns/iter 0.97
JSONSchema_Validate_Draft4_Items_Schema 6189.345535714454 ns/iter 6420.6160714278385 ns/iter 0.96
JSONSchema_Validate_Draft4_Nested_Object 156.05243303572334 ns/iter 162.70707562770912 ns/iter 0.96
JSONSchema_Validate_Draft4_Properties_Triad_Optional 5286.257000000205 ns/iter 5440.660714286188 ns/iter 0.97
JSONSchema_Validate_Draft4_Properties_Triad_Closed 4329.758125000182 ns/iter 4463.535000000007 ns/iter 0.97
JSONSchema_Validate_Draft4_Properties_Triad_Required 5384.6920000000855 ns/iter 5519.956999999068 ns/iter 0.98
JSONSchema_Validate_Draft4_Non_Recursive_Ref 538.338124999882 ns/iter 553.6350892857708 ns/iter 0.97
JSONSchema_Validate_Draft4_Pattern_Properties_True 7866.79129464269 ns/iter 8050.736607143299 ns/iter 0.98
JSONSchema_Validate_Draft4_Ref_To_Single_Property 417.6530706405439 ns/iter 410.90239679280097 ns/iter 1.02
JSONSchema_Validate_Draft4_Additional_Properties_Type 743.607924107183 ns/iter 751.3512276786015 ns/iter 0.99
JSONSchema_Validate_Draft4_Nested_Oneof 1060.610781250304 ns/iter 1092.5446875001298 ns/iter 0.97
JSONSchema_Validate_Draft6_Property_Names 1919.518883391782 ns/iter 1904.7180399267368 ns/iter 1.01
JSONSchema_Validate_Draft7_If_Then_Else 555.385699999988 ns/iter 559.5943750000133 ns/iter 0.99
JSONSchema_Compiler_Draft6_AdaptiveCard 10145076499.99996 ns/iter 10133277100.000101 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <[email protected]>
@jviotti jviotti merged commit c611809 into main Oct 11, 2024
13 checks passed
@jviotti jviotti deleted the detect-unevaluated branch October 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant