Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClangFormat installation on Linux #1299

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix ClangFormat installation on Linux #1299

merged 1 commit into from
Oct 14, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 13, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: ac879bd Previous: 80035b1 Ratio
JSON_Array_Of_Objects_Unique 4097.090111001962 ns/iter 3524.4809743153646 ns/iter 1.16
JSONSchema_Validate_Draft4_Meta_1_No_Callback 974.8119597181387 ns/iter 732.9016436046949 ns/iter 1.33
JSONSchema_Validate_Draft4_Required_Properties 1199.8009438589238 ns/iter 925.0930892596449 ns/iter 1.30
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 195.7085152726485 ns/iter 152.13577630639696 ns/iter 1.29
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 136.17790155967344 ns/iter 103.58019963067537 ns/iter 1.31
JSONSchema_Validate_Draft4_Items_Schema 3440.7673671010953 ns/iter 2641.4814997005737 ns/iter 1.30
JSONSchema_Validate_Draft4_Nested_Object 23.856875080930983 ns/iter 23.272336820529222 ns/iter 1.03
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1337.9037808230473 ns/iter 1318.7281112081664 ns/iter 1.01
JSONSchema_Validate_Draft4_Properties_Triad_Closed 984.2286658470041 ns/iter 959.7773795244619 ns/iter 1.03
JSONSchema_Validate_Draft4_Properties_Triad_Required 1325.2026688474655 ns/iter 1308.460280615523 ns/iter 1.01
JSONSchema_Validate_Draft4_Non_Recursive_Ref 247.40066371803135 ns/iter 212.77591336091416 ns/iter 1.16
JSONSchema_Validate_Draft4_Pattern_Properties_True 1401.1615189944748 ns/iter 1357.962821058604 ns/iter 1.03
JSONSchema_Validate_Draft4_Ref_To_Single_Property 111.19568818678617 ns/iter 105.38767637184328 ns/iter 1.06
JSONSchema_Validate_Draft4_Additional_Properties_Type 421.52929488830017 ns/iter 407.06509162632284 ns/iter 1.04
JSONSchema_Validate_Draft4_Nested_Oneof 371.8132727664314 ns/iter 357.7076872471596 ns/iter 1.04
JSONSchema_Validate_Draft6_Property_Names 797.2914130666376 ns/iter 772.9132230947268 ns/iter 1.03
JSONSchema_Validate_Draft7_If_Then_Else 173.76167915372437 ns/iter 167.93387209758976 ns/iter 1.03
JSONSchema_Compiler_Draft6_AdaptiveCard 3015682374.9998693 ns/iter 2959068749.9999146 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: ac879bd Previous: 80035b1 Ratio
JSON_Array_Of_Objects_Unique 5075.306999999611 ns/iter 5009.974999998121 ns/iter 1.01
JSONSchema_Validate_Draft4_Meta_1_No_Callback 2281.798122993127 ns/iter 2282.832050410901 ns/iter 1.00
JSONSchema_Validate_Draft4_Required_Properties 2001.7668992935323 ns/iter 2015.2740314951293 ns/iter 0.99
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 551.7669999999271 ns/iter 551.9125892858158 ns/iter 1.00
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 416.62977268772767 ns/iter 417.4175339714386 ns/iter 1.00
JSONSchema_Validate_Draft4_Items_Schema 6266.335714286697 ns/iter 6272.371428571384 ns/iter 1.00
JSONSchema_Validate_Draft4_Nested_Object 155.1193080357243 ns/iter 153.79663375905193 ns/iter 1.01
JSONSchema_Validate_Draft4_Properties_Triad_Optional 5375.149999999849 ns/iter 5327.908928569919 ns/iter 1.01
JSONSchema_Validate_Draft4_Properties_Triad_Closed 4495.624374999352 ns/iter 4385.980624999775 ns/iter 1.02
JSONSchema_Validate_Draft4_Properties_Triad_Required 5531.14732142847 ns/iter 5409.059999999499 ns/iter 1.02
JSONSchema_Validate_Draft4_Non_Recursive_Ref 560.7574999999088 ns/iter 565.3479000000061 ns/iter 0.99
JSONSchema_Validate_Draft4_Pattern_Properties_True 8032.2622767857265 ns/iter 7989.553571428689 ns/iter 1.01
JSONSchema_Validate_Draft4_Ref_To_Single_Property 416.1454769578333 ns/iter 420.0249026824129 ns/iter 0.99
JSONSchema_Validate_Draft4_Additional_Properties_Type 787.8708705355564 ns/iter 788.8535714284066 ns/iter 1.00
JSONSchema_Validate_Draft4_Nested_Oneof 1081.3676562499097 ns/iter 1077.0853124999035 ns/iter 1.00
JSONSchema_Validate_Draft6_Property_Names 1852.9971901766228 ns/iter 1857.9991589278716 ns/iter 1.00
JSONSchema_Validate_Draft7_If_Then_Else 550.3888392857854 ns/iter 554.3655357141931 ns/iter 0.99
JSONSchema_Compiler_Draft6_AdaptiveCard 10175684700.000147 ns/iter 9988133800.000013 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: ac879bd Previous: 80035b1 Ratio
JSON_Array_Of_Objects_Unique 1851.861019283261 ns/iter 2129.7482971443546 ns/iter 0.87
JSONSchema_Validate_Draft4_Meta_1_No_Callback 958.5417861831456 ns/iter 1021.1851785119057 ns/iter 0.94
JSONSchema_Validate_Draft4_Required_Properties 1566.0571147105836 ns/iter 1611.5520017007527 ns/iter 0.97
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 179.77785085144166 ns/iter 182.76400297425715 ns/iter 0.98
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 127.65929145205689 ns/iter 129.66637334385214 ns/iter 0.98
JSONSchema_Validate_Draft4_Items_Schema 3488.7861970239874 ns/iter 3594.868101734803 ns/iter 0.97
JSONSchema_Validate_Draft4_Nested_Object 34.02851378787857 ns/iter 33.26358328181035 ns/iter 1.02
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1753.2611536801155 ns/iter 1793.6127672764378 ns/iter 0.98
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1470.8313989181768 ns/iter 1479.0515503703514 ns/iter 0.99
JSONSchema_Validate_Draft4_Properties_Triad_Required 1835.9268126766628 ns/iter 1905.5036980436253 ns/iter 0.96
JSONSchema_Validate_Draft4_Non_Recursive_Ref 471.5587037609859 ns/iter 482.0217641950772 ns/iter 0.98
JSONSchema_Validate_Draft4_Pattern_Properties_True 2371.8319213249247 ns/iter 2447.526124983162 ns/iter 0.97
JSONSchema_Validate_Draft4_Ref_To_Single_Property 128.54816411161408 ns/iter 132.27309908139276 ns/iter 0.97
JSONSchema_Validate_Draft4_Additional_Properties_Type 588.646963920169 ns/iter 602.0956787476762 ns/iter 0.98
JSONSchema_Validate_Draft4_Nested_Oneof 453.42872510730393 ns/iter 506.9532063418618 ns/iter 0.89
JSONSchema_Validate_Draft6_Property_Names 1179.87775612034 ns/iter 1296.15426143517 ns/iter 0.91
JSONSchema_Validate_Draft7_If_Then_Else 198.0875742292153 ns/iter 208.64915032281078 ns/iter 0.95
JSONSchema_Compiler_Draft6_AdaptiveCard 5185036792.000006 ns/iter 5559734777.000017 ns/iter 0.93

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: ac879bd Previous: 80035b1 Ratio
JSONSchema_Compiler_Draft6_AdaptiveCard 5366825274.000007 ns/iter 6180430808.999972 ns/iter 0.87
JSONSchema_Validate_Draft4_Meta_1_No_Callback 944.277675847519 ns/iter 1074.8940526989795 ns/iter 0.88
JSONSchema_Validate_Draft4_Required_Properties 1668.4383197756642 ns/iter 2256.9993685172067 ns/iter 0.74
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 179.1066459523663 ns/iter 196.71809818803362 ns/iter 0.91
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 124.79530116239849 ns/iter 142.61018772140514 ns/iter 0.88
JSONSchema_Validate_Draft4_Items_Schema 3451.225957277826 ns/iter 3086.2665121873865 ns/iter 1.12
JSONSchema_Validate_Draft4_Nested_Object 24.99555407089027 ns/iter 23.958393336813533 ns/iter 1.04
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1742.5018533092311 ns/iter 1717.1716713770718 ns/iter 1.01
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1463.4940250274 ns/iter 1393.5436000399366 ns/iter 1.05
JSONSchema_Validate_Draft4_Properties_Triad_Required 1847.0448363965597 ns/iter 1773.2287017166484 ns/iter 1.04
JSONSchema_Validate_Draft4_Non_Recursive_Ref 527.6169883215438 ns/iter 469.92206579551583 ns/iter 1.12
JSONSchema_Validate_Draft4_Pattern_Properties_True 2356.5716516870225 ns/iter 2239.314230668066 ns/iter 1.05
JSONSchema_Validate_Draft4_Ref_To_Single_Property 128.5320152448819 ns/iter 145.01920213261306 ns/iter 0.89
JSONSchema_Validate_Draft4_Additional_Properties_Type 562.8197901531396 ns/iter 1116.5152927213971 ns/iter 0.50
JSONSchema_Validate_Draft4_Nested_Oneof 438.76145279569306 ns/iter 432.30519235504585 ns/iter 1.01
JSONSchema_Validate_Draft6_Property_Names 1303.4324019031023 ns/iter 1585.0089575930424 ns/iter 0.82
JSONSchema_Validate_Draft7_If_Then_Else 195.88790343112709 ns/iter 202.75580146277298 ns/iter 0.97
JSON_Array_Of_Objects_Unique 1983.8191048730819 ns/iter 3223.1306541919316 ns/iter 0.62

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit e8aa461 into main Oct 14, 2024
13 checks passed
@jviotti jviotti deleted the fix-clang-format-linux branch October 14, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant