Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard export includes in every public header #1303

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Guard export includes in every public header #1303

merged 1 commit into from
Oct 14, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 14, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 557290a Previous: dcc7200 Ratio
JSON_Array_Of_Objects_Unique 1872.3040008164628 ns/iter 1870.3187277091042 ns/iter 1.00
Compiler_Draft6_AdaptiveCard 5160611702.999972 ns/iter 5186515953.999958 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 980.1362647731506 ns/iter 982.9305306710622 ns/iter 1.00
Evaluator_Draft4_Required_Properties 1626.8342935242924 ns/iter 1626.874154938542 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 185.28483582211513 ns/iter 188.90183361154433 ns/iter 0.98
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 123.84573129752526 ns/iter 124.11070953940852 ns/iter 1.00
Evaluator_Draft4_Items_Schema 3704.6174881622564 ns/iter 3734.323508213844 ns/iter 0.99
Evaluator_Draft4_Nested_Object 32.97776438380864 ns/iter 32.051981160396984 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Optional 1760.9838743704288 ns/iter 1725.079881098483 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Closed 1410.9658244634566 ns/iter 1460.0907509554736 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Required 1805.8041472433683 ns/iter 1805.164813363267 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 470.52462326167233 ns/iter 472.24295487525006 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 2337.842155938399 ns/iter 2382.4437858418373 ns/iter 0.98
Evaluator_Draft4_Ref_To_Single_Property 125.16964161218135 ns/iter 125.60483243409766 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 576.6693738252732 ns/iter 577.3783992926237 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 485.81701314160136 ns/iter 494.0700344479851 ns/iter 0.98
Evaluator_Draft6_Property_Names 1222.7053700837898 ns/iter 1246.488919452931 ns/iter 0.98
Evaluator_Draft7_If_Then_Else 208.39781910193346 ns/iter 209.88590917471367 ns/iter 0.99
Evaluator_2020_12_Dynamic_Ref 3302.512873179828 ns/iter 3264.719156667398 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 557290a Previous: dcc7200 Ratio
Evaluator_2020_12_Dynamic_Ref 3733.7603358240995 ns/iter 3813.918160527042 ns/iter 0.98
Evaluator_Draft7_If_Then_Else 209.21505542989954 ns/iter 215.30053465184264 ns/iter 0.97
Evaluator_Draft6_Property_Names 1303.4113850037284 ns/iter 1311.9087204335399 ns/iter 0.99
Evaluator_Draft4_Meta_1_No_Callback 1003.782326019992 ns/iter 945.82798259592 ns/iter 1.06
Evaluator_Draft4_Required_Properties 1679.4074676523448 ns/iter 1669.8251505216874 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 185.3439000720329 ns/iter 180.46260271649817 ns/iter 1.03
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 128.28040838493627 ns/iter 126.92111782939567 ns/iter 1.01
Evaluator_Draft4_Items_Schema 3536.998720980662 ns/iter 3531.3848283690627 ns/iter 1.00
Evaluator_Draft4_Nested_Object 24.374655916441213 ns/iter 27.757603041599932 ns/iter 0.88
Evaluator_Draft4_Properties_Triad_Optional 1755.233454345178 ns/iter 1730.377135983718 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 1487.0280271098902 ns/iter 1459.1538176267588 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Required 1856.7769296171623 ns/iter 1810.940010791519 ns/iter 1.03
Evaluator_Draft4_Non_Recursive_Ref 531.3008125227797 ns/iter 516.5998498299572 ns/iter 1.03
Evaluator_Draft4_Pattern_Properties_True 2278.1418391740494 ns/iter 2239.14848597188 ns/iter 1.02
Evaluator_Draft4_Ref_To_Single_Property 130.94496197431295 ns/iter 132.23776512464767 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 575.2201298828934 ns/iter 574.8973504880565 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 472.577183646061 ns/iter 459.92714274346577 ns/iter 1.03
Compiler_Draft6_AdaptiveCard 5334006192.999936 ns/iter 5213529884.999957 ns/iter 1.02
JSON_Array_Of_Objects_Unique 1923.0833647281838 ns/iter 1894.2779221562707 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 557290a Previous: dcc7200 Ratio
JSON_Array_Of_Objects_Unique 3555.928872456834 ns/iter 3524.4735654568276 ns/iter 1.01
Compiler_Draft6_AdaptiveCard 2861471917.000017 ns/iter 2950641499.9999604 ns/iter 0.97
Evaluator_Draft4_Meta_1_No_Callback 750.0541621494885 ns/iter 765.858422591543 ns/iter 0.98
Evaluator_Draft4_Required_Properties 941.2614142976796 ns/iter 933.4179259934622 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 155.4932333367742 ns/iter 152.11738412611282 ns/iter 1.02
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 105.58431480648639 ns/iter 104.03532234549847 ns/iter 1.01
Evaluator_Draft4_Items_Schema 2672.791050821543 ns/iter 2637.8712793300565 ns/iter 1.01
Evaluator_Draft4_Nested_Object 22.890081973745005 ns/iter 23.52449118359853 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Optional 1257.0563195726513 ns/iter 1315.9646994450834 ns/iter 0.96
Evaluator_Draft4_Properties_Triad_Closed 955.7600277595755 ns/iter 975.1195987456857 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Required 1284.9783772230837 ns/iter 1348.3031815452437 ns/iter 0.95
Evaluator_Draft4_Non_Recursive_Ref 214.76071697163277 ns/iter 212.59035981158456 ns/iter 1.01
Evaluator_Draft4_Pattern_Properties_True 1390.9441738801645 ns/iter 1353.841369304453 ns/iter 1.03
Evaluator_Draft4_Ref_To_Single_Property 105.4155116084432 ns/iter 106.56729954044972 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 405.87974844062967 ns/iter 404.5404972901826 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 367.7871315462872 ns/iter 367.9497753030654 ns/iter 1.00
Evaluator_Draft6_Property_Names 778.3625558986924 ns/iter 783.5318242188841 ns/iter 0.99
Evaluator_Draft7_If_Then_Else 169.09848807079058 ns/iter 178.17315395495953 ns/iter 0.95
Evaluator_2020_12_Dynamic_Ref 2940.451143654788 ns/iter 2954.559862047694 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 557290a Previous: dcc7200 Ratio
JSON_Array_Of_Objects_Unique 4906.34200000045 ns/iter 4851.144509950205 ns/iter 1.01
Compiler_Draft6_AdaptiveCard 10322685800.000044 ns/iter 9829075999.999872 ns/iter 1.05
Evaluator_Draft4_Meta_1_No_Callback 2287.205483029607 ns/iter 2278.5999122771536 ns/iter 1.00
Evaluator_Draft4_Required_Properties 2007.5382673416475 ns/iter 1982.156319370807 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 575.4957999999988 ns/iter 556.315799999993 ns/iter 1.03
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 424.0978653724269 ns/iter 414.4451466764968 ns/iter 1.02
Evaluator_Draft4_Items_Schema 6444.347321428877 ns/iter 6366.958035714885 ns/iter 1.01
Evaluator_Draft4_Nested_Object 158.8652901785638 ns/iter 161.30069196432623 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Optional 5425.982000000432 ns/iter 5335.67800000128 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Closed 4475.638096101312 ns/iter 4405.119657178959 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Required 5481.345535714459 ns/iter 5441.696000000319 ns/iter 1.01
Evaluator_Draft4_Non_Recursive_Ref 570.6759821428875 ns/iter 562.8154999999424 ns/iter 1.01
Evaluator_Draft4_Pattern_Properties_True 8172.733258929707 ns/iter 8018.22625791916 ns/iter 1.02
Evaluator_Draft4_Ref_To_Single_Property 430.25424999996176 ns/iter 422.3572691182775 ns/iter 1.02
Evaluator_Draft4_Additional_Properties_Type 800.1955357142622 ns/iter 793.59866071422 ns/iter 1.01
Evaluator_Draft4_Nested_Oneof 1117.357187500012 ns/iter 1091.9509375000302 ns/iter 1.02
Evaluator_Draft6_Property_Names 1839.095124192197 ns/iter 1817.1091626499074 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 562.8393750000223 ns/iter 553.9108000000397 ns/iter 1.02
Evaluator_2020_12_Dynamic_Ref 8816.174107142415 ns/iter 8876.332589284886 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 1f8309e into main Oct 14, 2024
13 checks passed
@jviotti jviotti deleted the export-guards branch October 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant