Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a list of all possible schema resources during compilation #1304

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 14, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: a51fe32 Previous: 1f8309e Ratio
JSON_Array_Of_Objects_Unique 3559.695870290915 ns/iter 3744.347395492898 ns/iter 0.95
Compiler_Draft6_AdaptiveCard 2857430167.000075 ns/iter 4385005874.999933 ns/iter 0.65
Evaluator_Draft4_Meta_1_No_Callback 739.9341564964037 ns/iter 815.4006179948369 ns/iter 0.91
Evaluator_Draft4_Required_Properties 932.2271222484337 ns/iter 1020.2027507430499 ns/iter 0.91
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 150.97081711181605 ns/iter 163.2750773378874 ns/iter 0.92
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 102.5410005575754 ns/iter 129.62172458496516 ns/iter 0.79
Evaluator_Draft4_Items_Schema 2809.8935687765907 ns/iter 2857.514006019123 ns/iter 0.98
Evaluator_Draft4_Nested_Object 22.90598688372429 ns/iter 27.576311768757492 ns/iter 0.83
Evaluator_Draft4_Properties_Triad_Optional 1242.3843525517125 ns/iter 1397.249282524177 ns/iter 0.89
Evaluator_Draft4_Properties_Triad_Closed 951.0961972550091 ns/iter 1012.4670168982035 ns/iter 0.94
Evaluator_Draft4_Properties_Triad_Required 1284.084009235382 ns/iter 1337.7267537045823 ns/iter 0.96
Evaluator_Draft4_Non_Recursive_Ref 212.82922228607603 ns/iter 227.36815983058673 ns/iter 0.94
Evaluator_Draft4_Pattern_Properties_True 1332.102969807519 ns/iter 1420.3377892113526 ns/iter 0.94
Evaluator_Draft4_Ref_To_Single_Property 105.18144049891035 ns/iter 108.02501573849497 ns/iter 0.97
Evaluator_Draft4_Additional_Properties_Type 404.21590745977767 ns/iter 412.77045836785663 ns/iter 0.98
Evaluator_Draft4_Nested_Oneof 366.2083907319171 ns/iter 372.34261879019726 ns/iter 0.98
Evaluator_Draft6_Property_Names 769.6193308623092 ns/iter 782.7082091811931 ns/iter 0.98
Evaluator_Draft7_If_Then_Else 167.71831680054385 ns/iter 169.62069197717125 ns/iter 0.99
Evaluator_2020_12_Dynamic_Ref 2867.6975475944096 ns/iter 2914.6049452280754 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: a51fe32 Previous: 1f8309e Ratio
JSON_Array_Of_Objects_Unique 1856.535250996401 ns/iter 1873.4954375670584 ns/iter 0.99
Compiler_Draft6_AdaptiveCard 5152547301.000027 ns/iter 5107689445.999995 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 994.3686944935139 ns/iter 1012.2152481013884 ns/iter 0.98
Evaluator_Draft4_Required_Properties 1639.8049502617266 ns/iter 1625.179368296952 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 178.87662662005255 ns/iter 190.43118412165697 ns/iter 0.94
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 125.47908654181437 ns/iter 125.09706178396166 ns/iter 1.00
Evaluator_Draft4_Items_Schema 3683.7975344513925 ns/iter 3699.794215534958 ns/iter 1.00
Evaluator_Draft4_Nested_Object 32.42913520945725 ns/iter 32.33934622992502 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1713.0923934590853 ns/iter 1721.5405208586858 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Closed 1441.2420856991905 ns/iter 1430.9629674229725 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 1781.169729263528 ns/iter 1817.292393644624 ns/iter 0.98
Evaluator_Draft4_Non_Recursive_Ref 472.65750769140993 ns/iter 472.9279191717693 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 2361.64971815983 ns/iter 2366.944712178007 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 127.0205303417589 ns/iter 127.83822949345632 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 577.2752283775999 ns/iter 578.772668286691 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 485.17908216991 ns/iter 497.71614926726363 ns/iter 0.97
Evaluator_Draft6_Property_Names 1249.4598371904399 ns/iter 1222.196027661447 ns/iter 1.02
Evaluator_Draft7_If_Then_Else 208.72862414423074 ns/iter 211.21854625905326 ns/iter 0.99
Evaluator_2020_12_Dynamic_Ref 3337.1856223126297 ns/iter 3268.740835536221 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: a51fe32 Previous: 1f8309e Ratio
Evaluator_2020_12_Dynamic_Ref 3746.3700558350433 ns/iter 3794.591816561471 ns/iter 0.99
Evaluator_Draft7_If_Then_Else 200.47768633697368 ns/iter 204.84167236091218 ns/iter 0.98
Evaluator_Draft6_Property_Names 1312.4913411344235 ns/iter 1293.8806476739705 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 963.7358973144502 ns/iter 968.5442046145163 ns/iter 1.00
Evaluator_Draft4_Required_Properties 1663.400310583266 ns/iter 1662.1132868027546 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 188.0907760406087 ns/iter 180.10822533018055 ns/iter 1.04
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 127.23741008808862 ns/iter 124.43336005728378 ns/iter 1.02
Evaluator_Draft4_Items_Schema 3462.7580797672663 ns/iter 3484.056714601152 ns/iter 0.99
Evaluator_Draft4_Nested_Object 24.918995487493426 ns/iter 24.084384256116994 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Optional 1718.6126209175727 ns/iter 1727.5318052520101 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Closed 1449.2404931203187 ns/iter 1450.3111697556135 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Required 1826.9736753191692 ns/iter 1820.3952701634917 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 520.8915931084357 ns/iter 534.673307304226 ns/iter 0.97
Evaluator_Draft4_Pattern_Properties_True 2240.59644107233 ns/iter 2203.094539102342 ns/iter 1.02
Evaluator_Draft4_Ref_To_Single_Property 132.57068947912086 ns/iter 126.28679745819171 ns/iter 1.05
Evaluator_Draft4_Additional_Properties_Type 570.8231313012448 ns/iter 587.6713833803865 ns/iter 0.97
Evaluator_Draft4_Nested_Oneof 452.5577190677421 ns/iter 456.458500491918 ns/iter 0.99
Compiler_Draft6_AdaptiveCard 5268804506.000038 ns/iter 5223344337.000072 ns/iter 1.01
JSON_Array_Of_Objects_Unique 1924.0284593656252 ns/iter 1897.4765755708975 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: a51fe32 Previous: 1f8309e Ratio
JSON_Array_Of_Objects_Unique 4861.020233053297 ns/iter 4861.711505991998 ns/iter 1.00
Compiler_Draft6_AdaptiveCard 10050621900.000124 ns/iter 10051556799.999958 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 2364.3368701596037 ns/iter 2345.2105522206302 ns/iter 1.01
Evaluator_Draft4_Required_Properties 2020.0145714412167 ns/iter 1998.5343063999278 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 549.7659821429579 ns/iter 560.6835714285045 ns/iter 0.98
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 411.58433430432194 ns/iter 414.50335649538425 ns/iter 0.99
Evaluator_Draft4_Items_Schema 6403.760714284041 ns/iter 6375.81339285731 ns/iter 1.00
Evaluator_Draft4_Nested_Object 161.73761160714102 ns/iter 158.41486607140862 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Optional 5454.287000000023 ns/iter 5598.872000000483 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Closed 4474.821177735186 ns/iter 4420.274075464988 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 5517.389999999978 ns/iter 5415.6430000000455 ns/iter 1.02
Evaluator_Draft4_Non_Recursive_Ref 548.2081250000143 ns/iter 560.8776785713587 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 8122.460937498894 ns/iter 8050.046875000153 ns/iter 1.01
Evaluator_Draft4_Ref_To_Single_Property 419.19706326743807 ns/iter 420.88932469249573 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 790.3677455356473 ns/iter 805.9635687661616 ns/iter 0.98
Evaluator_Draft4_Nested_Oneof 1111.5651562498385 ns/iter 1093.8273437499647 ns/iter 1.02
Evaluator_Draft6_Property_Names 1920.4494871089005 ns/iter 1825.547969239112 ns/iter 1.05
Evaluator_Draft7_If_Then_Else 550.4173214284996 ns/iter 549.6598999999378 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref 8964.146142203064 ns/iter 8747.780143839998 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit b378cd6 into main Oct 14, 2024
13 checks passed
@jviotti jviotti deleted the schema-resources-list branch October 14, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant