Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit step schema resources as hashes #1306

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Emit step schema resources as hashes #1306

merged 1 commit into from
Oct 14, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 14, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti force-pushed the hashed-schema-resources branch 2 times, most recently from c22fd3e to 07b40a3 Compare October 14, 2024 19:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 2dd984d Previous: 7d89944 Ratio
JSON_Array_Of_Objects_Unique 3520.6581944029126 ns/iter 3526.589275693622 ns/iter 1.00
Compiler_Draft6_AdaptiveCard 2805888708.0001116 ns/iter 2886706499.9999456 ns/iter 0.97
Evaluator_Draft4_Meta_1_No_Callback 734.3188636083643 ns/iter 788.5864336608646 ns/iter 0.93
Evaluator_Draft4_Required_Properties 919.1338090696376 ns/iter 942.5052974646587 ns/iter 0.98
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 151.49026211476294 ns/iter 150.82408162813857 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 102.50534555965417 ns/iter 104.59020106228397 ns/iter 0.98
Evaluator_Draft4_Items_Schema 2636.9298650077853 ns/iter 2642.513595448415 ns/iter 1.00
Evaluator_Draft4_Nested_Object 23.066882872422067 ns/iter 22.882256755094225 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Optional 1264.3524428788683 ns/iter 1250.2354584755092 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 965.5858013505209 ns/iter 956.1677598995284 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 1289.6096095810979 ns/iter 1298.2150737781965 ns/iter 0.99
Evaluator_Draft4_Non_Recursive_Ref 213.29695393631076 ns/iter 213.96519620466776 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 1336.5838739046008 ns/iter 1353.4096300934643 ns/iter 0.99
Evaluator_Draft4_Ref_To_Single_Property 104.82843929750547 ns/iter 106.47670650414248 ns/iter 0.98
Evaluator_Draft4_Additional_Properties_Type 403.400857336319 ns/iter 408.63746901771344 ns/iter 0.99
Evaluator_Draft4_Nested_Oneof 370.88610598560444 ns/iter 364.492578340592 ns/iter 1.02
Evaluator_Draft6_Property_Names 832.202777800661 ns/iter 776.3324258922434 ns/iter 1.07
Evaluator_Draft7_If_Then_Else 177.03030145487782 ns/iter 172.12546421466942 ns/iter 1.03
Evaluator_2020_12_Dynamic_Ref 1436.4067248389183 ns/iter 2955.570011813018 ns/iter 0.49

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 2dd984d Previous: 7d89944 Ratio
JSON_Array_Of_Objects_Unique 1827.884174549065 ns/iter 1877.376217256541 ns/iter 0.97
Compiler_Draft6_AdaptiveCard 4958768253.000016 ns/iter 5209861585.999989 ns/iter 0.95
Evaluator_Draft4_Meta_1_No_Callback 974.9260436185508 ns/iter 963.7540302518255 ns/iter 1.01
Evaluator_Draft4_Required_Properties 1638.8050952279762 ns/iter 1584.0124031113728 ns/iter 1.03
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 174.39239718847742 ns/iter 174.6088348344846 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 122.18274789432724 ns/iter 125.5933688836554 ns/iter 0.97
Evaluator_Draft4_Items_Schema 3443.0455454794915 ns/iter 3542.6082461632277 ns/iter 0.97
Evaluator_Draft4_Nested_Object 32.08867768971698 ns/iter 31.50840593989135 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Optional 1673.5119378044697 ns/iter 1686.4515947060213 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Closed 1395.421323416617 ns/iter 1414.4980951017717 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 1761.422392453429 ns/iter 1778.791122563804 ns/iter 0.99
Evaluator_Draft4_Non_Recursive_Ref 491.8459450395831 ns/iter 477.6118074903072 ns/iter 1.03
Evaluator_Draft4_Pattern_Properties_True 2426.1664686538475 ns/iter 2311.1436753639014 ns/iter 1.05
Evaluator_Draft4_Ref_To_Single_Property 128.05955676001466 ns/iter 129.21412939052732 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 615.9410043944798 ns/iter 593.21381654877 ns/iter 1.04
Evaluator_Draft4_Nested_Oneof 459.11018017769874 ns/iter 464.4607110311913 ns/iter 0.99
Evaluator_Draft6_Property_Names 1234.0922212228327 ns/iter 1238.1798921659088 ns/iter 1.00
Evaluator_Draft7_If_Then_Else 201.97757839430838 ns/iter 204.26232596645931 ns/iter 0.99
Evaluator_2020_12_Dynamic_Ref 1773.0038852565874 ns/iter 3445.1647073635586 ns/iter 0.51

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 2dd984d Previous: 7d89944 Ratio
Evaluator_2020_12_Dynamic_Ref 1880.9833660538443 ns/iter 3633.978034638864 ns/iter 0.52
Evaluator_Draft7_If_Then_Else 199.20808956825508 ns/iter 193.9079829940825 ns/iter 1.03
Evaluator_Draft6_Property_Names 1288.5773002698663 ns/iter 1297.5866886580438 ns/iter 0.99
Evaluator_Draft4_Meta_1_No_Callback 973.3030609326557 ns/iter 964.4314563783954 ns/iter 1.01
Evaluator_Draft4_Required_Properties 1651.889596443302 ns/iter 1668.7073565499288 ns/iter 0.99
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 176.6921013109421 ns/iter 188.56572711816096 ns/iter 0.94
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 128.01419500759405 ns/iter 134.96957625256485 ns/iter 0.95
Evaluator_Draft4_Items_Schema 3389.1586987066144 ns/iter 3511.677342852524 ns/iter 0.97
Evaluator_Draft4_Nested_Object 25.530807895554798 ns/iter 23.83261473801737 ns/iter 1.07
Evaluator_Draft4_Properties_Triad_Optional 1732.0792283079516 ns/iter 1721.9342614603725 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 1460.401745941126 ns/iter 1456.4519790680847 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Required 1822.259661848143 ns/iter 1810.1252568724597 ns/iter 1.01
Evaluator_Draft4_Non_Recursive_Ref 535.2871281938693 ns/iter 538.0855460575794 ns/iter 0.99
Evaluator_Draft4_Pattern_Properties_True 2293.726153523337 ns/iter 2345.2457896826127 ns/iter 0.98
Evaluator_Draft4_Ref_To_Single_Property 131.36296384404963 ns/iter 132.74880120767048 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 579.4382666742918 ns/iter 576.3109434416609 ns/iter 1.01
Evaluator_Draft4_Nested_Oneof 437.9172238106615 ns/iter 438.1923970537112 ns/iter 1.00
Compiler_Draft6_AdaptiveCard 4969400775.000053 ns/iter 5240878876.0000105 ns/iter 0.95
JSON_Array_Of_Objects_Unique 1953.8167281774938 ns/iter 1865.2393921761436 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 2dd984d Previous: 7d89944 Ratio
JSON_Array_Of_Objects_Unique 5033.175000000938 ns/iter 4945.967000001019 ns/iter 1.02
Compiler_Draft6_AdaptiveCard 9721191299.999872 ns/iter 9814097199.999878 ns/iter 0.99
Evaluator_Draft4_Meta_1_No_Callback 2400.4834816034404 ns/iter 2263.403124999996 ns/iter 1.06
Evaluator_Draft4_Required_Properties 2044.192794857985 ns/iter 1956.2521930820878 ns/iter 1.04
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 555.5808035714855 ns/iter 552.3571999999604 ns/iter 1.01
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 410.7855307685389 ns/iter 412.0216313426442 ns/iter 1.00
Evaluator_Draft4_Items_Schema 6436.962499999968 ns/iter 6408.515178571455 ns/iter 1.00
Evaluator_Draft4_Nested_Object 156.2367857142683 ns/iter 162.39589285714626 ns/iter 0.96
Evaluator_Draft4_Properties_Triad_Optional 5448.216964284468 ns/iter 5436.904000000595 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Closed 4480.5784455237335 ns/iter 4419.771874999868 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 5499.190999998972 ns/iter 5418.570535716023 ns/iter 1.01
Evaluator_Draft4_Non_Recursive_Ref 557.5963392857375 ns/iter 569.3101785713648 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 8146.8828124999145 ns/iter 8146.367187501978 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 405.6795488535869 ns/iter 412.99381229824746 ns/iter 0.98
Evaluator_Draft4_Additional_Properties_Type 779.0172991073113 ns/iter 796.949218749938 ns/iter 0.98
Evaluator_Draft4_Nested_Oneof 1102.9351562498846 ns/iter 1065.3790779557237 ns/iter 1.04
Evaluator_Draft6_Property_Names 1933.1966367828963 ns/iter 1798.1499090625637 ns/iter 1.08
Evaluator_Draft7_If_Then_Else 558.3053000000291 ns/iter 551.9090000000233 ns/iter 1.01
Evaluator_2020_12_Dynamic_Ref 4759.818660308442 ns/iter 8797.312065571981 ns/iter 0.54

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti marked this pull request as ready for review October 14, 2024 19:54
@jviotti jviotti merged commit c8a0c03 into main Oct 14, 2024
13 checks passed
@jviotti jviotti deleted the hashed-schema-resources branch October 14, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant