Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LogicalNot to AnnotationNot #1307

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Rename LogicalNot to AnnotationNot #1307

merged 1 commit into from
Oct 14, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 14, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti changed the title Rename LogicalNot to LogicalNotWithMask Rename LogicalNot to AnnotationNot Oct 14, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 1ca0ccb Previous: c8a0c03 Ratio
JSON_Array_Of_Objects_Unique 3505.4837172037996 ns/iter 3534.9168876609747 ns/iter 0.99
Compiler_Draft6_AdaptiveCard 2807046666.000133 ns/iter 2791473083.000028 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 736.1610762588055 ns/iter 732.782291313407 ns/iter 1.00
Evaluator_Draft4_Required_Properties 923.6679553383588 ns/iter 932.5981061172159 ns/iter 0.99
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 151.24556455606796 ns/iter 150.47735724008103 ns/iter 1.01
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 103.60540858451013 ns/iter 104.0341985829844 ns/iter 1.00
Evaluator_Draft4_Items_Schema 2615.034962576158 ns/iter 2613.4992278007935 ns/iter 1.00
Evaluator_Draft4_Nested_Object 22.853049400303778 ns/iter 24.11290127860588 ns/iter 0.95
Evaluator_Draft4_Properties_Triad_Optional 1275.1287851375425 ns/iter 1257.9937641764511 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 971.5030645713716 ns/iter 943.8705633815686 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Required 1311.2229647055603 ns/iter 1274.5960401168054 ns/iter 1.03
Evaluator_Draft4_Non_Recursive_Ref 216.0563126794114 ns/iter 211.55723937181915 ns/iter 1.02
Evaluator_Draft4_Pattern_Properties_True 1325.7423185914513 ns/iter 1339.5653426768692 ns/iter 0.99
Evaluator_Draft4_Ref_To_Single_Property 104.6172513160174 ns/iter 104.70214307581404 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 406.28385278262675 ns/iter 423.18006574434753 ns/iter 0.96
Evaluator_Draft4_Nested_Oneof 369.21187717230106 ns/iter 362.30830378683424 ns/iter 1.02
Evaluator_Draft6_Property_Names 772.0877084756019 ns/iter 762.878492254532 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 169.0210428956825 ns/iter 168.05931057183483 ns/iter 1.01
Evaluator_2020_12_Dynamic_Ref 1428.5696346646887 ns/iter 1393.247566769046 ns/iter 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 1ca0ccb Previous: c8a0c03 Ratio
JSON_Array_Of_Objects_Unique 1854.7909150240985 ns/iter 1827.995144986077 ns/iter 1.01
Compiler_Draft6_AdaptiveCard 4914438438.99998 ns/iter 5075923687.000056 ns/iter 0.97
Evaluator_Draft4_Meta_1_No_Callback 1023.2736725016523 ns/iter 982.4707532046976 ns/iter 1.04
Evaluator_Draft4_Required_Properties 1618.6364497336233 ns/iter 1636.8762350890881 ns/iter 0.99
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 178.99919671403296 ns/iter 175.4563522630317 ns/iter 1.02
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 134.72970654839423 ns/iter 122.36637141927112 ns/iter 1.10
Evaluator_Draft4_Items_Schema 3632.5457775606133 ns/iter 3448.8139853182397 ns/iter 1.05
Evaluator_Draft4_Nested_Object 33.333931329172145 ns/iter 33.2608243027564 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1718.9234777725064 ns/iter 1686.710211223213 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Closed 1418.6776816150575 ns/iter 1402.3854933860164 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 1813.4133762930112 ns/iter 1775.578637726959 ns/iter 1.02
Evaluator_Draft4_Non_Recursive_Ref 483.1467761991774 ns/iter 470.03770454375854 ns/iter 1.03
Evaluator_Draft4_Pattern_Properties_True 2423.122931417662 ns/iter 2414.997444625056 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 131.3448436280635 ns/iter 127.57073156745098 ns/iter 1.03
Evaluator_Draft4_Additional_Properties_Type 618.6880467221025 ns/iter 590.7205249693924 ns/iter 1.05
Evaluator_Draft4_Nested_Oneof 480.0033874062787 ns/iter 469.556621779953 ns/iter 1.02
Evaluator_Draft6_Property_Names 1368.744475604533 ns/iter 1226.9451716729677 ns/iter 1.12
Evaluator_Draft7_If_Then_Else 208.37643525241378 ns/iter 200.33312391678942 ns/iter 1.04
Evaluator_2020_12_Dynamic_Ref 1822.641788469006 ns/iter 1799.0174188541991 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 1ca0ccb Previous: c8a0c03 Ratio
Evaluator_2020_12_Dynamic_Ref 1916.0053398366922 ns/iter 1892.3239998803776 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 202.80318345474993 ns/iter 194.29898660742242 ns/iter 1.04
Evaluator_Draft6_Property_Names 1286.5444919231268 ns/iter 1271.4985804980945 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 967.0817852951219 ns/iter 942.6422020811544 ns/iter 1.03
Evaluator_Draft4_Required_Properties 1668.5468381850847 ns/iter 1664.8369532374604 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 193.25812706009532 ns/iter 183.02461082735488 ns/iter 1.06
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 133.05499655256963 ns/iter 132.17396658344555 ns/iter 1.01
Evaluator_Draft4_Items_Schema 3528.674115998374 ns/iter 3484.771545486577 ns/iter 1.01
Evaluator_Draft4_Nested_Object 25.781912848541914 ns/iter 24.817811857387714 ns/iter 1.04
Evaluator_Draft4_Properties_Triad_Optional 1772.9784278388775 ns/iter 1753.8564113363418 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 1576.2105593847207 ns/iter 1434.1936510416313 ns/iter 1.10
Evaluator_Draft4_Properties_Triad_Required 1895.6586455204272 ns/iter 1809.9647985966508 ns/iter 1.05
Evaluator_Draft4_Non_Recursive_Ref 540.6208140941014 ns/iter 552.6372653973273 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 2420.6424991958143 ns/iter 2320.8755010779423 ns/iter 1.04
Evaluator_Draft4_Ref_To_Single_Property 136.69497148412012 ns/iter 132.86326865371672 ns/iter 1.03
Evaluator_Draft4_Additional_Properties_Type 601.1654416537375 ns/iter 593.577043705755 ns/iter 1.01
Evaluator_Draft4_Nested_Oneof 451.2007219126318 ns/iter 437.2129876175034 ns/iter 1.03
Compiler_Draft6_AdaptiveCard 4994334359.00005 ns/iter 5063568662.999955 ns/iter 0.99
JSON_Array_Of_Objects_Unique 1959.9442956126227 ns/iter 2045.2004448099754 ns/iter 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 1ca0ccb Previous: c8a0c03 Ratio
JSON_Array_Of_Objects_Unique 4963.038392856691 ns/iter 5264.1140000014275 ns/iter 0.94
Compiler_Draft6_AdaptiveCard 9611190899.999884 ns/iter 9798267200.000055 ns/iter 0.98
Evaluator_Draft4_Meta_1_No_Callback 2288.070325814899 ns/iter 2420.483214285696 ns/iter 0.95
Evaluator_Draft4_Required_Properties 1970.49122365303 ns/iter 2058.2423864313137 ns/iter 0.96
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 548.5368999998173 ns/iter 558.0905000001621 ns/iter 0.98
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 410.3169504321914 ns/iter 413.15882571678645 ns/iter 0.99
Evaluator_Draft4_Items_Schema 6173.046428569607 ns/iter 6440.30245535784 ns/iter 0.96
Evaluator_Draft4_Nested_Object 157.92801339285592 ns/iter 156.9702232142589 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Optional 5484.682999999677 ns/iter 5511.577678571403 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Closed 4565.593750000118 ns/iter 4484.078507019829 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Required 5572.064999998929 ns/iter 5527.881249999415 ns/iter 1.01
Evaluator_Draft4_Non_Recursive_Ref 569.6256250000635 ns/iter 559.0033035714116 ns/iter 1.02
Evaluator_Draft4_Pattern_Properties_True 8088.4419642858675 ns/iter 8192.002232141655 ns/iter 0.99
Evaluator_Draft4_Ref_To_Single_Property 408.2606871311968 ns/iter 407.0428077213534 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 808.2027901785693 ns/iter 781.2539062501044 ns/iter 1.03
Evaluator_Draft4_Nested_Oneof 1063.586093749791 ns/iter 1132.7017187500844 ns/iter 0.94
Evaluator_Draft6_Property_Names 1985.0453404520033 ns/iter 1990.2746543242295 ns/iter 1.00
Evaluator_Draft7_If_Then_Else 554.0645535715173 ns/iter 567.6239285713385 ns/iter 0.98
Evaluator_2020_12_Dynamic_Ref 4685.759343212597 ns/iter 4730.139223339093 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 5abaac6 into main Oct 14, 2024
13 checks passed
@jviotti jviotti deleted the not-with-mask branch October 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant