Correctly canonicalize relative URIs that do not begin with /
#1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
force-pushed
the
uri-canonicalize-relative
branch
from
07b0bcf
to
b1d143d
Compare
Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
uri-canonicalize-relative
branch
from
b1d143d
to
48e7cd1
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: 48e7cd1 | Previous: 3b644bf | Ratio |
|---|---|---|---|
JSON_Array_Of_Objects_Unique |
4029.1436853675436 ns/iter |
4075.7306550110193 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 48e7cd1 | Previous: 3b644bf | Ratio |
|---|---|---|---|
JSON_Array_Of_Objects_Unique |
2095.612813975955 ns/iter |
2056.5590829182497 ns/iter |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 48e7cd1 | Previous: 3b644bf | Ratio |
|---|---|---|---|
JSON_Array_Of_Objects_Unique |
3371.0350210861347 ns/iter |
3213.6516983010065 ns/iter |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: 48e7cd1 | Previous: 3b644bf | Ratio |
|---|---|---|---|
JSON_Array_Of_Objects_Unique |
4357.059999999535 ns/iter |
4329.911250000151 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]