Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typed-builder from 0.14.0 to 0.15.1 #2676

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2023

Bumps typed-builder from 0.14.0 to 0.15.1.

Changelog

Sourced from typed-builder's changelog.

0.15.1 - 2023-07-10

Fixed

  • no-std build.

0.15.0 - 2023-07-06

Changed

  • [BREAKING] Split the derive macro out to a separate procmacro crate. This is considered a breaking change because reexporting and/or renmaing the crate can now prevent the generated code from finding the types it needs (see issue #101)

Fixed

  • Marking a field as #[deprecated] now behaves properly - TypedBuilder generated code itself does trigger the deprecation warning, and instead the setter for that field now does.
  • The "fake" build method when required fields are not provided now returns the never type ("!"). Refer to PR #97 for more thorough explanation.

Added

  • Support for setter method prefixes and suffixes #[builder(field_defaults(setter(prefix = "...", suffix = "...")))]. This either prepends or appends the provided string to the setter method. This allows method names like: set_x(), with_y(), or set_z_value().
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust labels Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #2676 (43ff571) into latest (a4856b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #2676   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files         133      133           
  Lines       15179    15179           
  Branches     2612     2612           
=======================================
  Hits        12942    12942           
  Misses       1936     1936           
  Partials      301      301           
Flag Coverage Δ
hypothesis-py ?
python 92.83% <ø> (ø)
rust 51.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dependabot dependabot bot force-pushed the dependabot/cargo/typed-builder-0.15.1 branch 3 times, most recently from f7bfd20 to 2dd49b6 Compare July 11, 2023 15:49
@ctb
Copy link
Contributor

ctb commented Jul 11, 2023

It looks like this falls afoul of ...something:

 error[E0658]: `let...else` statements are unstable
Error:    --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/typed-builder-macro-0.15.1/src/field_info.rs:138:21
    |
138 | /                     let Some(path) = path_to_single_string(&list.path) else {
139 | |                         continue;
140 | |                     };
    | |______________________^
    |
    = note: see issue #87335 <https://github.com/rust-lang/rust/issues/87335> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `typed-builder-macro` due to previous error

I will dig in and close if it looks like this is a problem w/backwards compatibility in rust.

@dependabot dependabot bot force-pushed the dependabot/cargo/typed-builder-0.15.1 branch from 2dd49b6 to 5e84c31 Compare July 18, 2023 23:44
@ctb
Copy link
Contributor

ctb commented Jul 19, 2023

@dependabot rebase

@ctb ctb enabled auto-merge (squash) July 19, 2023 11:36
@dependabot dependabot bot force-pushed the dependabot/cargo/typed-builder-0.15.1 branch from 5e84c31 to 81dacc9 Compare July 19, 2023 11:37
@ctb
Copy link
Contributor

ctb commented Jul 19, 2023

I think maybe #2680 will have fixed this.

@ctb
Copy link
Contributor

ctb commented Jul 19, 2023

no, was not fixed it seems.

@dependabot dependabot bot force-pushed the dependabot/cargo/typed-builder-0.15.1 branch from 81dacc9 to f263af0 Compare July 19, 2023 12:14
@luizirber
Copy link
Member

It looks like this falls afoul of ...something:

error[E0658]: let...else statements are unstable

This syntax was introduced in 1.65, so we would have to bump MSRV to support it.

@dependabot dependabot bot force-pushed the dependabot/cargo/typed-builder-0.15.1 branch 3 times, most recently from c5777cb to e6c5634 Compare July 24, 2023 22:11
Bumps [typed-builder](https://github.com/idanarye/rust-typed-builder) from 0.14.0 to 0.15.1.
- [Changelog](https://github.com/idanarye/rust-typed-builder/blob/master/CHANGELOG.md)
- [Commits](https://github.com/idanarye/rust-typed-builder/commits)

---
updated-dependencies:
- dependency-name: typed-builder
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/typed-builder-0.15.1 branch from e6c5634 to 43ff571 Compare August 1, 2023 10:30
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 7, 2023

Superseded by #2706.

@dependabot dependabot bot closed this Aug 7, 2023
auto-merge was automatically disabled August 7, 2023 20:11

Pull request was closed

@dependabot dependabot bot deleted the dependabot/cargo/typed-builder-0.15.1 branch August 7, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants