-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade rocksdb to 0.22.0 #3383
Conversation
CodSpeed Performance ReportMerging #3383 will not alter performanceComparing Summary
|
Ah, it would require bumping the minimum |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3383 +/- ##
==========================================
- Coverage 86.47% 86.46% -0.01%
==========================================
Files 137 137
Lines 16092 16092
Branches 2219 2219
==========================================
- Hits 13915 13914 -1
- Misses 1870 1871 +1
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is OK for us, we try to keep the MSRV compatible with what is available in Debian. What is the current Rust available in Debian? I usually check https://packages.debian.org/search?keywords=rustc but it is 503 now, repology says |
On a Debian system, you can run
And repology is also a decent source, yes 👍🏻 https://packages.ubuntu.com/rustc Okay, shall I bump the MSRV and retry this PR? In Debian we are getting a weird error with the older https://paste.debian.net/1334814/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mr-c!
## [0.17.2] - 2024-11-15 MSRV: 1.66 Changes/additions: * enforce a single scaled on a `CollectionSet` (#3397) * change `sig_from_record` to use scaled from `Record` to downsample (#3387) Updates: * Upgrade rocksdb to 0.22.0, bump MSRV to 1.66 (#3383) * Bump thiserror from 1.0.68 to 2.0.3 (#3389) * Bump csv from 1.3.0 to 1.3.1 (#3390) * Bump tempfile from 3.13.0 to 3.14.0 (#3391)
Seeing if we can upgrade to the latest rocksdb safely.