Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rocksdb to 0.22.0 #3383

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Nov 7, 2024

Seeing if we can upgrade to the latest rocksdb safely.

Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #3383 will not alter performance

Comparing mr-c:rocksdb_0.22.0 (399776a) with latest (de1a597)

Summary

✅ 21 untouched benchmarks

@mr-c
Copy link
Contributor Author

mr-c commented Nov 7, 2024

Ah, it would require bumping the minimum rustc version to 1.66

@mr-c mr-c closed this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (de1a597) to head (399776a).
Report is 2 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3383      +/-   ##
==========================================
- Coverage   86.47%   86.46%   -0.01%     
==========================================
  Files         137      137              
  Lines       16092    16092              
  Branches     2219     2219              
==========================================
- Hits        13915    13914       -1     
- Misses       1870     1871       +1     
  Partials      307      307              
Flag Coverage Δ
hypothesis-py 25.43% <ø> (ø)
python 92.40% <ø> (ø)
rust 62.23% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luizirber
Copy link
Member

Ah, it would require bumping the minimum rustc version to 1.66

This is OK for us, we try to keep the MSRV compatible with what is available in Debian. What is the current Rust available in Debian? I usually check https://packages.debian.org/search?keywords=rustc but it is 503 now, repology says 1.63 for bookworm and up to 1.82 for trixie?

@mr-c
Copy link
Contributor Author

mr-c commented Nov 8, 2024

Ah, it would require bumping the minimum rustc version to 1.66

This is OK for us, we try to keep the MSRV compatible with what is available in Debian. What is the current Rust available in Debian? I usually check https://packages.debian.org/search?keywords=rustc but it is 503 now,

On a Debian system, you can run rmadison rustc (or any Debian package name) to see which versions are in the official archive.

repology says 1.63 for bookworm and up to 1.82 for trixie?

And repology is also a decent source, yes 👍🏻

https://packages.ubuntu.com/rustc

Okay, shall I bump the MSRV and retry this PR?

In Debian we are getting a weird error with the older rocksdb crate, so I wanted to see if the newer version broke anything for sourmash.

https://paste.debian.net/1334814/

thread 'test_column_family_with_transactiondb' panicked at core/src/panicking.rs:221:5:
unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap

@mr-c mr-c marked this pull request as ready for review November 13, 2024 16:46
@luizirber luizirber self-requested a review November 13, 2024 17:27
Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mr-c!

@luizirber luizirber enabled auto-merge (squash) November 13, 2024 17:28
@luizirber luizirber merged commit c6cadb4 into sourmash-bio:latest Nov 13, 2024
41 of 43 checks passed
@mr-c mr-c deleted the rocksdb_0.22.0 branch November 13, 2024 17:30
ctb added a commit that referenced this pull request Nov 15, 2024
## [0.17.2] - 2024-11-15

MSRV: 1.66

Changes/additions:

* enforce a single scaled on a `CollectionSet` (#3397)
* change `sig_from_record` to use scaled from `Record` to downsample
(#3387)

Updates:

* Upgrade rocksdb to 0.22.0, bump MSRV to 1.66  (#3383)
* Bump thiserror from 1.0.68 to 2.0.3 (#3389)
* Bump csv from 1.3.0 to 1.3.1 (#3390)
* Bump tempfile from 3.13.0 to 3.14.0 (#3391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants