fix: Avoid re-calculating md5sum on clone and conversion to KmerMinHashBTree #3385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging sourmash-bio/sourmash_plugin_branchwater#503 the flamegraph showed ~26% of the time was spent on calculating MD5.
WHY????
Turns out cloning and converting to
KmerMinHash
toKmerMinHashBTree
triggered recalculation of the MD5 sum, even if it was already present (or... not needed). Oops!