WIP: integrate sketching utils from directsketch #516
+1,562
−117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
directsketch
, I tried to come up with a set of sketching utils that would make reading parameters + building sketches easier and more standardized. I introduced a series of buildutils --BuildRecord
,BuildManifest
,BuildCollection
, etc that are similar to their sourmash counterparts, but enable building and updating.Here, I copy the utils over from
directsketch
and replace the two async functions with sync counterparts that enable writing the sigs and manifest from the buildutils. Then, I useBuildCollection
inmanysketch
to manage parameter string handling, sig template generation, and sig writing.To do:
Future: