[MRG] add max_containment column #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
requested changes
Aug 30, 2023
|
tests added in #85 |
* [MRG] add mastiff interface functions (#58) * try adding rdb index and manysearch * init testing * use pathlist loading for better errs; more tests * also check intersect_hashes * add test for index check * add multiquery mastiff gather * init mastiff gather testing * remove original single-query mastiff search, gather * more cleanup * MRG: fix `if let` warnings (#63) * fix threads for changes from main * rm threshold * [MRG] allow index from a signature zipfile (#74) * zipfile hackaround * fix * fix tests * clean up; unify search testing; pin core to commit * upd py toml * test index zip * add some indexed fastmultigather testing * add cargo lock * more index tests * indexed multigather tests * revert to branch while trying upds * better help; avoid recalc threshold * EXP: try fix CI for rocksdb (#80) * Add trial workflow * ok weird removing sourmash * try again * do the test * remove maturin CI for the moment * try caching rust build stuff * fix yaml syntax * test actions --------- Co-authored-by: C. Titus Brown <[email protected]> * improve gather output * cargo lock * re add jaccard * added test for max cont * version and cite * rm warning * bump versions --------- Co-authored-by: Tessa Pierce Ward <[email protected]>
…3_branchwater into max_containment
… into max_containment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #75
also: because of #85,
Fixes #83
Fixes #77
Fixes #84