-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix interpolation issue in the splunk_login_successful method #205
Conversation
fac3e7f
to
f301543
Compare
@haidangwa can you please rebase instead of doing a merge commit update to keep the history linear? Also please address the chefspec issues. |
Working on it now -- was having issues with my testing environment, but that seems to be resolved now, ATM.
|
6283047
to
f42b64b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@haidangwa looks like we need to deal with some Chef 17 issues before we can get this merged unfortunately. |
@ramereth I'm running the latest chef-workstation on my laptop and the test for uninstall-forwarder passes in Test Kitchen with Chef 17. I'm not sure why this is failing in Github Actions. |
@haidangwa I can replicate the problem on my end with 17.1.35. I suspect it has something to do with the |
The issue is between Chef Infra Client v17.0.150 and 17.0.242. All tests pass under v17.0.150, but the uninstall-forwarder tests fail under 17.0.242 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Kind Prediction: fix Provide the bot with feedback using a 👍 or 👎! |
@ramereth I've narrowed this down even further. Using kitchen-dokken, the chef infra clients pass all the way through and including 17.0.194. It breaks between 17.0.194 and 17.0.199. That seems definitive that it is a Chef Infra Client bug. 17.0.194: PASS
17.0.199: FAIL *uninstall-forwarder test suites
based on tags from docker hub |
looks like ruby 3.0.1 was added to the chef omnibus_overrides.rb between v17.0.197 and v17.0.198
|
I think getting this cookbook to be compatible with Chef Infra Client 17 is beyond the scope of this PR. Fixing the changes to be Chef 17 compatible should be in itself a separate Pull Request. |
@ramereth OK. With all that said (above), I am thinking the problem is in the
Note:
However, the error does not fail for the It's also not that the custom resource doesn't have access to the node object, as I confirmed this by adding a log resource right before my custom resource uses the service resource. My log resource did not fail in my test.
In fact, it worked fine, as demonstrated in my chef run output, below:
|
@haidangwa so it looks like some of the fixes you have in here were done in #215 and conflicts with this. Can you please rebase and resolve the conflicts? Thanks! |
- Fixes an issue with the `user-seed.conf` file - Ensures that splunk is installed prior to anything in the `chef-splunk::service` recipe executes Signed-off-by: Dang H. Nguyen <[email protected]>
- set `unified_mode true` in all custom resources Signed-off-by: Dang H. Nguyen <[email protected]>
- Renames inspec files to end with `_test.rb` rather than `_spec.rb` to distinguish from chefspec files Signed-off-by: Dang H. Nguyen <[email protected]>
…om Splunk; therefore, this change will use the 8.0.9 RPM instead Signed-off-by: Dang H. Nguyen <[email protected]>
… presentation of `ps 1` command Signed-off-by: Dang H. Nguyen <[email protected]>
…version dependency to `~> 4.0.0` for unified mode
…n initializing a search head cluster member
Signed-off-by: Lance Albertson <[email protected]>
This reverts commit 60b647d.
This reverts commit 5f5ce92.
Hey @haidangwa can you reopen this PR when you have a clean branch. Thanks! Looks like some great work here. |
Description
user-seed.conf
filechef-splunk::service
recipe executesIssues Resolved
#204
Check List