Add inline annotations #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without enabling link time optimization (LTO) there will never be any inlining across crate boundaries. These methods will be mostly called from other crates, they are small and used in hot loops. On a branch of rust-png-reader that was made to use Circular this change reduced the runtime of one benchmark test from 3 minutes 30 seconds to 1 minute 40 seconds (so over 50%). (The benchmark is running the example/stats binary on a large (50GB) PGN file downloaded from the lichess DB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without enabling link time optimization (LTO) there will never be any inlining across crate boundaries. These methods will be mostly called from other crates, they are small and used in hot loops.
On a branch of rust-png-reader that was made to use Circular this change reduced the runtime of one benchmark test from 3 minutes 30 seconds to 1 minute 40 seconds (so over 50%).
(The benchmark is running the example/stats binary on a large (50GB) PGN file downloaded from the lichess DB)