Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tls): use right method to get cn and san attributes and display them in cli #974

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

FlorentinDUBOIS
Copy link
Collaborator

No description provided.

* Needed by dependencies time

Signed-off-by: Florentin Dubois <[email protected]>
* Bump clap to 4.3.19
* Bump jemallocator to 0.5.4
* Bump serde to 1.0.181
* Bump serde_json to 1.0.104
* Bump time to 0.3.25
* Bump tempfile to 3.7.0
* Bump x509-parser to 0.15.1
* Bump thiserror to 1.0.44
* Bump rustls to 0.21.6

Signed-off-by: Florentin Dubois <[email protected]>
Copy link
Member

@Keksoj Keksoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good overall. Please document the new methods.

command/src/certificate.rs Show resolved Hide resolved
command/src/certificate.rs Show resolved Hide resolved
lib/src/tls.rs Show resolved Hide resolved
command/src/certificate.rs Outdated Show resolved Hide resolved
Copy link
Member

@Keksoj Keksoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay!

@Keksoj Keksoj merged commit 2b23b76 into main Aug 4, 2023
12 checks passed
@FlorentinDUBOIS FlorentinDUBOIS deleted the devel/fdubois/fix/pem-parsing branch August 4, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants