Add jank client #92
Add jank client #92
Conversation
docs/setup/clients/jank/web.md
Outdated
| ``` | ||
| !!! note | ||
|
|
||
| Jank Client defualts to opening on port 8080, if you want to change the port you'll need to change either the env variable PORT or put the port on the command you run so it'd be like node ./index.js 43 |
There was a problem hiding this comment.
| Jank Client defualts to opening on port 8080, if you want to change the port you'll need to change either the env variable PORT or put the port on the command you run so it'd be like node ./index.js 43 | |
| Jank Client defaults to opening on port 8080, if you want to change the port you'll need to change either the env variable PORT or put the port on the command you run, ex: `node ./index.js 43` |
Co-authored-by: Puyodead1 <[email protected]>
Co-authored-by: Puyodead1 <[email protected]>
docs/setup/clients/jank/web.md
Outdated
| ``` | ||
| !!! note | ||
|
|
||
| Jank Client defualts to opening on port 8080, if you want to change the port you'll need to change either the env variable PORT or put the port on the command you run, ex: `npm start ./index.js 43` |
There was a problem hiding this comment.
This is a development tool. Rewrite the build instructions to compile a static web root and provide instructions to serve with nginx or similar.
There was a problem hiding this comment.
I pinged you on discord so we could talk about this with most instance comunication
| - Fork (Jank Client)[https://github.com/MathMan05/JankClient] | ||
| - Run the building instructions. | ||
| - Commit & push. | ||
| - Pull request & done! |
There was a problem hiding this comment.
Is there a non-pull request flow for folks who don't use, or prefer not to use GitHub?
There was a problem hiding this comment.
not as of now, I only have a github
There was a problem hiding this comment.
do you not have discord/spacebar?
There was a problem hiding this comment.
I do have github/spacebar, though I don't know how exactly that's supposed to work, as neither are git providors
There was a problem hiding this comment.
sending in patches outside of git (eg. git format-patch -> git am *.patch), via any means of communication that can share one or more files :)
There was a problem hiding this comment.
I mean technically that'd work, but as with the official client
I don't really want to encourage that type of commit
There was a problem hiding this comment.
fair, i guess im probably one of few people who would prefer to just send in patch files than whatever the hell messy thing that is github fork+pr :P
docs/setup/clients/jank/web.md
Outdated
| - More settings, and general bug fixes, CSS improvements or anything you think needs to be fixed/improved | ||
| - [This](https://github.com/users/MathMan05/projects/1/views/1) is a good list for things that need to be done, though it's incomplete, so if you think something is missing and you want to add it, just do it! MathMan05 is more than willing to answer your questions if you have any! | ||
| - Even if you can't code, there's stuff you can still do! Like [reporting bugs](https://github.com/MathMan05/JankClient/issues), or updating the documentation! Even if you don't help Jank Client directly, if you contributed to the Spacebar server itself, it'd still be a huge help towards Jank Client, especially if you improve/fix op codes 8/14. | ||
| - If you have an instance you can put it on Jank Clients [instance list](https://github.com/MathMan05/JankClient/blob/main/InstanceInfo.md), if you don't it'll show up on Jank Client if it's on the official instance list, but it's good if you do put it on the list as it'll let Jank Client have some additional information, and your instance will be higher on the list, even if you partially fill it out, Jank Client will merge both listings so no information is lost. |
There was a problem hiding this comment.
Perhaps provide a link to the official instance list?
There was a problem hiding this comment.
as in, include a direct link to the official intance list instead of just saying "this thing i dont provide a link to", just use a masked link to the repo or something
There was a problem hiding this comment.
Oh, I need to rewrite for clarity, that's not what that means
There was a problem hiding this comment.
i meant more, the "if you don't it'll show up on Jank Client if it's on the official instance list," part
Add jank client to the docs