Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the minimum distance to 0, so fine adjustments are possible
Makes the selectUpper/selectLower gestures simultaneous so they won't delay the dragging. There might need to be some logic here to revert to the previous value if they tapped but slightly moved their thumb
Refactors some (
Horizontal{Value,Range}Slider
s) to use@GestureState
- which properly tracks when gestures are cancelled (whichonEnd
does not do). The others need updating, but I'm lazyFixes simultaneous gestures when using interactive track, and putting a finger on the thumb and track
Adds
precisionScrubbing
which lets you move your finger down to slow down the scrubbing speed:-It may look like extra ceremony declaring an enum for scrubbing speeds - and you may think you could just return a float. However - it's absolutely critical that there are a limited number of values returned for the scrubbing speed. When going from a slower to faster scrubbing speed (e.g. 8x slow down to 4x), you have to 'undo' the 8x adjustments, and apply them to the 4x. This is what happens in the iOS video player (although they managed to animate this change). This basically means storing every speed and the corresponding offset accumulations in a dictionary, and if the user could freely return any float, and they may be tempted to use linear interpolation for the speed, which would make the dictionary huge