[draft] NodeSet is an Array #2617
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-nodeset-is-an-array
branch
from
79a1c62
to
6f33bc1
Compare
flavorjones
force-pushed
the
flavorjones-nodeset-is-an-array
branch
from
6f33bc1
to
b95f586
Compare
flavorjones
commented
Oct 15, 2024
| @@ -6,70 +6,44 @@ module XML | |||
| # A NodeSet contains a list of Nokogiri::XML::Node objects. Typically | |||
| # a NodeSet is return as a result of searching a Document via | |||
| # Nokogiri::XML::Searchable#css or Nokogiri::XML::Searchable#xpath | |||
| class NodeSet | |||
| class NodeSet < ::Array | |||
There was a problem hiding this comment.
I think it's going to be better to use DelegateClass(Array) here, see https://rubyapi.org/o/delegator and https://rubyapi.org/3.3/o/object#method-i-DelegateClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Draft implementation of NodeSet using an Array for storage, see #2184 for background and context.
Have you included adequate test coverage?
Existing test coverage should be sufficient.
Does this change affect the behavior of either the C or the Java implementations?
Right now this PR just addresses the C implementation to demonstrate the approach and get feedback from CI.