Add xmlsec native library #2901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maths22
commented
Jun 6, 2023
| @@ -2,12 +2,12 @@ FROM ruby:alpine3.12 | |||
|
|
|||
| # prelude | |||
| RUN apk update | |||
| RUN apk add bash build-base git | |||
| RUN apk add bash build-base git perl | |||
There was a problem hiding this comment.
Perl is needed because the openssl build scripts are not autotools based but rather require perl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Pre-work for #2888 to have native libraries available in CI. As can be seen here: https://github.com/maths22/nokogiri/actions/runs/5190697036/jobs/9357995415 , the build is almost passing using these images and the remaining issues will not require a new version of CI images.
Open issue for discussion: the 32-bit port of Ubuntu focal is a "partial port" and only includes a subset of packages. Notably, xmlsec is not among those packages. Therefore, using the Ubuntu focal base image with native xmlsec for 32 bit testing isn't really feasible. We could possibly build that package in a PPA, or we could explore basing the 32 bit image on the
ruby:${version}images, which are Debian bullseye (which has complete 32bit architecture support) instead of Ubuntu. (Best I can tell that image is only used for the cibasicstep, so I would think we could be flexible there, but I'm open to other thoughts.)Have you included adequate test coverage?
n/a
Does this change affect the behavior of either the C or the Java implementations?
No, it is a build only change