Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use ragel options to minimize states and use gotos #2950

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtarchie
Copy link

@jtarchie jtarchie commented Aug 10, 2023

What problem is this PR intended to solve?

No problem.

Experimenting with the features of ragel for faster parsing tables for gumbo.
I'd like to see if the tests passed through CI.

Have you included adequate test coverage?

This shouldn't affect the functionality.
This relies on ragel and the C compiler for better optimizations in parsing.

Does this change affect the behavior of either the C or the Java implementations?

As far as I know, just the C implementation.

@stevecheckoway
Copy link
Contributor

It's nice to see someone looking at this!

I played with the various options a few years ago and couldn't get better output. Looks like this choice of options ends up with 50k more lines of code to compile.

I'm curious how this choice impacts the size of the binary, compilation time, and runtime parsing performance.

@flavorjones
Copy link
Member

Thanks, @jtarchie! I kicked off CI and have an HTML5 benchmark on my dev machine that I'll run a comparison with.

@jtarchie
Copy link
Author

jtarchie commented Aug 11, 2023

There are file differences:

  • char_ref.c goes from 692K -> 1.4M in size
  • the object file goes from 298K -> 870K
  • with -O3, the object file is 367K (taking 12s to compile over the 0.5s without any -O flag above)

The object file shows the size difference that would affect the binary.

This may not give the speed increase needed, based on the changelog ragel originally made this faster. This might have already hit the speed sweet spot. It might not be the bottleneck it once was.

@jtarchie
Copy link
Author

=Is this something I can help explore still?

@flavorjones
Copy link
Member

@jtarchie Thanks for asking. I definitely want to understand the tradeoffs between size, compilation speed (less of an issue these days), and runtime performance. It's on my list of things to explore next month when I have some free time to work on OSS.

@flavorjones flavorjones added this to the v1.18.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants