FontAwesome 5 compatibility #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need plz ! |
|
This has been implemented in my fork of the project: https://github.com/Ionaru/easy-markdown-editor |
|
Any chance this could be added in? |
|
Is there anyone who wants to co-maintain this package? I've pinged the original authors to see if they need help but my expertise is in other languages so would appreciate backup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compatibility for FontAwesome 5 by creating a seperate element for the icon and nesting it inside the button element instead of putting the classes on the button element. This makes sure that the button and all its properties stays intact when FontAwesome 5 changes elements to
<svg>for their icons.FontAwesome 4 works with this change as well. There are no visual differences except that the icon has shifted 1px up, probably because of some centering by FontAwesome.
Fixes #664