Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake argument #24

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Add fake argument #24

merged 3 commits into from
Dec 9, 2024

Conversation

francoism90
Copy link
Contributor

@francoism90 francoism90 commented Dec 9, 2024

This depends on spatie/mailcoach-mailer#19

It would allow to pass fake to the mailer.

Please let me know if I'm missing something, it looks like this will pass fake in its payload, but unfortunately I cannot test Mailcoach locally atm.

@@ -69,7 +69,7 @@ public function replacing(array|string $key, string|array|null $value = null): s
return $this;
}

public function fake(bool $value): self
public function faking(bool $value): self
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freekmurze
Copy link
Member

Nice, added some docs on this here: https://www.mailcoach.app/resources/learn-mailcoach/features/transactional

@freekmurze freekmurze merged commit 97d8586 into spatie:main Dec 9, 2024
21 checks passed
@freekmurze
Copy link
Member

Thanks!

@francoism90
Copy link
Contributor Author

francoism90 commented Dec 9, 2024

@freekmurze Thanks for the merge, and adding instructions! :)

Do not forget to merge spatie/mailcoach-mailer#19 - it's a depend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants