Add resolve condition pass #1645
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phschaad
reviewed
Sep 7, 2024
| import ast | ||
|
|
||
|
|
||
| def eliminate_branch(sdfg: sd.SDFG, initial_edge: sd.graph.Edge): |
There was a problem hiding this comment.
Looks like yes, it should become a reusable, documented utility function :-)
There was a problem hiding this comment.
Agreed! This one is a good candidate for "building block" used by multiple transformations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass takes a Python condition as a string (e.g. "flag == True"), parses it and, assuming it always holds throughout the SDFG, it deletes all unsatisfiable branches.
This is a first step towards implementing "specialized SDFGs". While playing with some code-replication inducing transformations I noticed that the graph quickly became too big to work with. This pass can help users generate different specialized SDFGs and work on those. As an example, if
flagis an input boolean that is never written two, two SDFGs, one withflagset to true and the other withflagset to false can be created and worked on indipendently.Creating as draft since multiple design decisions are still unclear to me