-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better CopyToMap
#1675
Open
philip-paul-mueller
wants to merge
11
commits into
spcl:main
Choose a base branch
from
philip-paul-mueller:better_copy_to_map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Better CopyToMap
#1675
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8187241
Updated the copy to map operation.
philip-paul-mueller dcbec9a
Added some more special cases to the copy to map.
philip-paul-mueller 3a3d8e2
Refactored the copy to map.
philip-paul-mueller 0de8a87
Fixed an error.
philip-paul-mueller 9463087
Modified the `CopyToMap` transformation, with regard to strides.
philip-paul-mueller 285bd09
Renmaed the bypass tests.
philip-paul-mueller bca885d
Updated `CopyToMap`.
philip-paul-mueller ffca7e0
Merge remote-tracking branch 'spcl/master' into better_copy_to_map
philip-paul-mueller 4d1e0f1
Merge branch 'master' into better_copy_to_map
philip-paul-mueller 2cef799
Fixed the copy to map test.
philip-paul-mueller 4ae2f4e
Removed the restriction of self copying.
philip-paul-mueller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we may need to call the
try_initialize
method before attempting to get src/dst subsets here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually not sure.
I was hit by this a few time in the past so I am in favour of keeping it.
However, the main reason why this function is used (I think I "discovered" it here) is because even in the original code it is used (see old line 70).
For that reason I decided to keep it.
But if you think we should remove that I will not object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, should we also add a call to the method that tries to initialize the edge/memlet to ensure that the src/dst subsets are not None when they are not supposed to.