-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle scoping for Picklists based on Field in Table #5044
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the back-end's job to figure out if a table can be scoped and if so scope it.
Front-end saying "domainFilter: true" should be interpreted as "scope these resources if you can, please"
@CarolineDenis This was reported again today by MCNB, can we add this to our timeline? It looks like the work is (largely) done on it already |
Encountered today myself testing COR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be done on the back-end, but I am ok with it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Create a PickList with type "Field From Table"
- Choose a Table which can not be scoped
- Some examples include:
- AccessionAuthorization
- Author
- CollectionRelationship
- CollectionRelType
- Disposal
- SpecifyUser
- SpQuery
- TaxonTreeDefItem
- Some examples include:
- Choose any field from the Table
- In any field on any table (can be different from the table chosen above) in the Schema Configuration, assign the PickList to the field
- Navigate to any form of the table which contains the field assigned to the PickList and ensure no error is thrown
- Navigate to any existing CollectionRelationship form
- Some Test Panel databases which contain CollectionRelationships:
- mpabi_2024_06_04
- KUFish_5_16_23
- SAIAB_11_24_23
- Some Test Panel databases which contain CollectionRelationships:
- Ensure an error does not occur and the
CollectionRelType
is properly populated
I get an error after creating a new picklist and when trying to open the collection relationship forms
Fixes #4989
The Issue here was that for Picklists based on field values for a table, the frontend was always trying to enforce scoping for for records of the table the "fictitious" Picklist Items were based off of.
See #4989 (comment)
Related: #3564
Checklist
and self-explanatory (or properly documented)
Testing instructions
CollectionRelType
is properly populated