QB Api change for handling MOTs #5251
Open
+86
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acwhite211
added
2 - Queries
|
Still need to add front-end code to use the new API request schema when using taxon ranks. |
|
Include in 7.9.7 if front-end can be finished this week, push to 7.9.8 if not |
acwhite211
requested review from
melton-jason,
realVinayak,
maxpatiiuk and
sharadsw
|
@acwhite211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4979
Fixes #5392
This should have been included in #5036 PR. This PR defines the new schema in the QB for specifying the treedefid of a rank. The new QB request schema for MOTs is
<table_id>.<table_name>.<treedef_id>,<rank>,<field>. The code is backwards compatible, so it still allows that old schema to be used. The front-end needs to be changed to send this new QB request schema when dealing with MOTs.Checklist
and self-explanatory (or properly documented)
Testing instructions
TBD