Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geo trees to tree creation tool #5372

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Add geo trees to tree creation tool #5372

merged 4 commits into from
Nov 15, 2024

Conversation

CarolineDenis
Copy link
Contributor

Fixes #5371

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • open tree viewer
  • click add a new tree
  • verify you can add each of the 3 new trees: Rocks - Minerals - Meteorites

@CarolineDenis CarolineDenis added this to the 7.9.9 milestone Nov 5, 2024
@CarolineDenis CarolineDenis requested review from sharadsw and a team November 5, 2024 15:52
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • open tree viewer
  • click add a new tree
  • verify you can add each of the 3 new trees: Rocks - Minerals - Meteorites

The new trees and their ranks are created correctly 👍👍👍👍

I do have a request though
image

Could the Empty Tree option be moved back to the bottom?

@alesan99 alesan99 requested a review from a team November 15, 2024 15:21
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • open tree viewer
  • click add a new tree
  • verify you can add each of the 3 new trees: Rocks - Minerals - Meteorites

Can add tree ranks in the create tree dialog

chrome_jYktMbiw3A.mp4

@CarolineDenis
Copy link
Contributor Author

@emenslin,
Thanks for the catch!
Second time it's been lost in a merge 😅

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • open tree viewer
  • click add a new tree
  • verify you can add each of the 3 new trees: Rocks - Minerals - Meteorites

Looks good, can add the new trees and can no longer add ranks in the create tree dialog

@emenslin emenslin requested a review from a team November 15, 2024 20:56
@CarolineDenis CarolineDenis merged commit a9e2075 into production Nov 15, 2024
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5371 branch November 15, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add geo trees to the tree creation library
4 participants