Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescope upload tree when there is only 1 tree in the upload plan #5385

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

sharadsw
Copy link
Contributor

@sharadsw sharadsw commented Nov 7, 2024

Fixes #5338

The upload tree wasn't being rescoped in cases where upload plan had only 1 tree, due to which upload would be scoped to the default tree of the collection which meant upload didn't work if the upload tree of the plan was not the same as the default tree

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  • Go to the workbench
  • Create an upload plan with only 1 tree which isn't the original tree
  • Verify upload works

@sharadsw sharadsw added this to the 7.9.9 milestone Nov 7, 2024
@sharadsw sharadsw requested review from acwhite211, CarolineDenis and a team November 7, 2024 16:34
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to the workbench
  • Create an upload plan with only 1 tree which isn't the original tree
  • Verify upload works

Uploading to a tree that is not the original will not connect a new child to the root node.

Uploading to the original tree:

chrome_1Bw2Kk5Mc9.mp4

There is different behavior depending on if the first rank is enforced or not. The first rank should always be enforced but it is possible to uncheck 'is enforced' for the top rank therefore this issue should be fixed for both cases.

Uploading to a different tree with first rank not enforced:

chrome_QhzZ1cvlKm.mp4

Uploading to a different tree with first rank enforced:

chrome_b9QrT3gdes.mp4

db: https://kufish212-issue-5338.test.specifysystems.org/specify/

@sharadsw
Copy link
Contributor Author

sharadsw commented Nov 15, 2024

What should be the expected behavior in both cases? It should use the existing root?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Dev Attention Needed
Development

Successfully merging this pull request may close these issues.

Cannot validate taxon in workbench if it is not the original tree
3 participants