Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex/#1678 faster diff #1688

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Alex/#1678 faster diff #1688

merged 7 commits into from
Jul 26, 2023

Conversation

AlexandruPopovici
Copy link
Contributor

@AlexandruPopovici AlexandruPopovici commented Jul 12, 2023

Description & motivation

Handles #1678

Changes:

  • Diffing is now significantly faster
  • Added another diffing method which uses strictly boolean operations. Disabled by default

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Jul 12, 2023
@AlexandruPopovici AlexandruPopovici merged commit 56058c0 into main Jul 26, 2023
1 check passed
@AlexandruPopovici AlexandruPopovici deleted the alex/#1679-faster-diff branch July 26, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants