Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Modes #3259

Merged
merged 71 commits into from
Oct 29, 2024
Merged

View Modes #3259

merged 71 commits into from
Oct 29, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

…works roughly the same as the older approach with 1 less texture fetch. Also implemented Canny
…ht now we've disabled MSAA and using TAA for stationary as an example
…ze calls. Struggled a *lot* with different blending results between drawing to the backbuffer and to a framebuffer then copying to the backbuffer. There are still some differences visible
Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

…erial instead of all it;s materials. This means that per object material changes like selection and filtering will work together with view modes. Handles WEB-2080, WEB-2083, WEB-2084, WEB-2081 and WEB-2082
… preexisting bug in production. Fixed an issue where the shadowcatcher would incorrectly blend in shaded view mode
…ansparent objects as well (was originally required)
…pth buffer for proper precision on MacOs Chromium
…when selecting hidden objects (outlines only mode)
Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici marked this pull request as ready for review October 28, 2024 16:14
Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit 613614d into main Oct 29, 2024
38 of 41 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/g-pipeline branch October 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants