Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Modes Support for Instances undead-patch #3411

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Coming as undead patch # 9 this PR adds support for overriding the batch material for instanced batches, and fixes the issues where some view modes did not work in streams with instances

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlexandruPopovici AlexandruPopovici changed the title View Modes Support for Instances undead-patch View Modes Support for Instances undead-patch#9 Oct 29, 2024
@AlexandruPopovici AlexandruPopovici changed the title View Modes Support for Instances undead-patch#9 View Modes Support for Instances undead-patch Oct 29, 2024
Copy link
Contributor

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit a5cc510 into main Oct 29, 2024
25 of 27 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/view-modes-undead-patch branch October 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants