Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section Box Fix #3428

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Section Box Fix #3428

merged 1 commit into from
Nov 1, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Made sure LegacyViewer passes over an actual Box3 object to the viewer

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link
Contributor

📸 Preview service has generated an image.

@gjedlicska gjedlicska merged commit 26a103b into main Nov 1, 2024
25 of 27 checks passed
@gjedlicska gjedlicska deleted the alex/section-box-whateverthefuck branch November 1, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants