Refactor usage of exceptions in converters/connectors #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanRynne
force-pushed
the
alan/exception-handling
branch
from
3ef63d6
to
d5d6a82
Compare
adamhathcock
previously requested changes
Oct 10, 2024
Converters/Civil3d/Speckle.Converters.Civil3dShared/Civil3dRootToHostConverter.cs
Outdated
Show resolved
Hide resolved
Converters/Revit/Speckle.Converters.RevitShared/Helpers/ParameterValueSetter.cs
Show resolved
Hide resolved
Converters/Revit/Speckle.Converters.RevitShared/RevitRootToHostConverter.cs
Show resolved
Hide resolved
|
Tested in ArcGIS:
|
| @@ -311,7 +313,7 @@ List<ObjectConversionTracker> listOfTrackers | |||
| { | |||
| if (trackerItem.HostAppGeom is not ACG.Geometry shape) | |||
| { | |||
| throw new SpeckleConversionException("Feature Class element had no converted geometry"); | |||
| throw new ValidationException("Feature Class element had no converted geometry"); | |||
There was a problem hiding this comment.
possibly we can replace some of the ArgumentExceptions in other converters to ValidationException too
AlanRynne
force-pushed
the
alan/exception-handling
branch
from
be82244
to
abeaa5e
Compare
JR-Morgan
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the existing exceptions right now:
Connectors now use exclusively
SpeckleExceptioninstead of a mix of that and conversionexceptions.The only place where
ConversionNotSupportedis expected is within aRootObjectConverter.ValidationExceptionis thrown if we can verify the data is wrong BEFORE we can attempt conversionConversionExceptionshould be used for anything else.We can expand the types more as we find more use-cases to unify.