Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Metrics in Connectors #296

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Oct 10, 2024

Uses ME.Console and OTel for logging to correlate

Copy link

linear bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 8.29%. Comparing base (0c5b5ed) to head (1fbe92b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
Sdk/Speckle.Connectors.Common/Connector.cs 0.00% 28 Missing ⚠️
...eckle.Connectors.Common/ConnectorMetricsFactory.cs 0.00% 8 Missing ⚠️
...ckle.Connectors.Common/ConnectorActivityFactory.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #296      +/-   ##
========================================
- Coverage   8.33%   8.29%   -0.05%     
========================================
  Files        243     244       +1     
  Lines       4857    4882      +25     
  Branches     569     569              
========================================
  Hits         405     405              
- Misses      4435    4460      +25     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adamhathcock and others added 4 commits October 14, 2024 09:03
…-in-sdkconnectors-where-traces-are' into adam/cxpla-56-instrument-metrics-in-sdkconnectors-where-traces-are
…nt-metrics-in-sdkconnectors-where-traces-are
@JR-Morgan JR-Morgan self-requested a review October 14, 2024 09:41
@adamhathcock adamhathcock enabled auto-merge (squash) October 14, 2024 10:27
@adamhathcock adamhathcock merged commit 4f04e9e into dev Oct 14, 2024
5 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-56-instrument-metrics-in-sdkconnectors-where-traces-are branch October 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants