Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(civil3d): adds property sets and parts data to all civil objects #297

Merged
merged 12 commits into from
Oct 11, 2024

Conversation

clairekuang
Copy link
Member

Adds parts data and property sets to all civil objects.

  • parts data is just a dictionary stored under "properties" on every object
  • property sets are more like revit parameters, and have definitions stored on the root collection. Each object can have multiple property sets, and each property set includes a property that is a dictionary (since properties can have diff unit types etc).

sample commit:
https://app.speckle.systems/projects/b53a53697a/models/719612f9da@002f35d400

Copy link

linear bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.72%. Comparing base (ed2d3ed) to head (1cc3cd3).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #297   +/-   ##
=====================================
  Coverage   8.72%   8.72%           
=====================================
  Files        232     232           
  Lines       4640    4640           
  Branches     542     542           
=====================================
  Hits         405     405           
  Misses      4218    4218           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing I see to stop this

@clairekuang clairekuang merged commit 8c34416 into dev Oct 11, 2024
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-444-add-property-sets-and-parts-data branch October 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants