feat(civil3d): adds subassembly and parcel props #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-all-civil3d-entities
…vil3d-entities' of https://github.com/specklesystems/speckle-sharp-connectors into claire/cnx-587-validate-properties-extracted-for-all-civil3d-entities
…com/specklesystems/speckle-sharp-connectors into claire/cnx-624-add-corridor-support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #305 +/- ##
=====================================
Coverage 8.41% 8.41%
=====================================
Files 240 240
Lines 4815 4815
Branches 556 556
=====================================
Hits 405 405
Misses 4393 4393
Partials 17 17 ☔ View full report in Codecov by Sentry. |
AlanRynne
approved these changes
Oct 16, 2024
| { | ||
| name = target.Name; // this will throw for some entities like labels | ||
| } | ||
| catch (Exception e) when (!e.IsFatal()) { } |
There was a problem hiding this comment.
Do we know the specific exception? Is there an Autocad generic exception we could use at least?
clairekuang
deleted the
claire/cnx-637-add-assembly-and-subassembly-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small pr to add some custom props for subassemblies and parcels
IMPORTANT: should be merged after #302