Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dui3): ensures we don't override structure layers #307

Conversation

didimitrie
Copy link
Member

where there's two materials of the same type in the same type, they would override each other; nevertheless, having two plywood layers for one wall is totally acceptable.

note: this is a poc solution for now, as i envision the whole parameter extractor stuff to be properly typed out.

where there's two materials of the same type in the same type, they would override each other; nevertheless, having two plywood layers for one wall is totally acceptable.
Copy link

linear bot commented Oct 17, 2024

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.40%. Comparing base (6e56c3c) to head (dd17d36).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...tShared/ToSpeckle/Parameters/ParameterExtractor.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #307      +/-   ##
========================================
- Coverage   8.41%   8.40%   -0.01%     
========================================
  Files        240     240              
  Lines       4815    4816       +1     
  Branches     556     556              
========================================
  Hits         405     405              
- Misses      4393    4394       +1     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie didimitrie merged commit 528c692 into dev Oct 18, 2024
5 checks passed
@didimitrie didimitrie deleted the dimitrie/cnx-649-assembly-structure-two-layers-with-the-same-material-name branch October 18, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants