Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(civil3d): refactors corridors to only use extracted solids once #318

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented Oct 23, 2024

Corridor solids were being attached to every applied subassembly.
This pr converts the assembly used for each region and attaches it in elements, as well as the subassemblies (which now contain the display meshes).
Other changes:

  • applied assemblies and applied subassemblies now sent as dictionaries instead of Base (a lot more lightweight).
  • refactors corridor solid extraction to its own display value extractor class

Sample commit: https://latest.speckle.systems/projects/3f895e614f/models/2533bf268e

changes applied assemblies and subassemblies to dicts
Copy link

linear bot commented Oct 23, 2024

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.40%. Comparing base (3088fae) to head (09a473d).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #318   +/-   ##
=====================================
  Coverage   8.40%   8.40%           
=====================================
  Files        240     240           
  Lines       4816    4816           
  Branches     556     556           
=====================================
  Hits         405     405           
  Misses      4394    4394           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -324,10 +365,9 @@ private void HandleCorridorSolids(CDB.Corridor corridor)
}

// get the (corridor handle, baseline guid, region guid, assembly handle, subassembly handle) of the solid property sets
(string corridor, string baseline, string region, string assembly, string subassembly)? solidKey =
GetCorridorSolidIdFromPropertySet(solid, tr);
(string, string, string, string, string)? solidKey = GetCorridorSolidIdFromPropertySet(solid, tr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made me blind, we should improve this

@clairekuang clairekuang changed the title fex(civil3d): refactors corridors to only use extracted solids once fix(civil3d): refactors corridors to only use extracted solids once Oct 23, 2024
@clairekuang clairekuang merged commit 68f7cb8 into dev Oct 24, 2024
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-676-duplicated-display-value-meshes-for-corridor-subassemblies branch October 24, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants