-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(civil3d): refactors corridors to only use extracted solids once #318
fix(civil3d): refactors corridors to only use extracted solids once #318
Conversation
changes applied assemblies and subassemblies to dicts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #318 +/- ##
=====================================
Coverage 8.40% 8.40%
=====================================
Files 240 240
Lines 4816 4816
Branches 556 556
=====================================
Hits 405 405
Misses 4394 4394
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Converters/Civil3d/Speckle.Converters.Civil3dShared/Helpers/CorridorHandler.cs
Outdated
Show resolved
Hide resolved
@@ -324,10 +365,9 @@ private void HandleCorridorSolids(CDB.Corridor corridor) | |||
} | |||
|
|||
// get the (corridor handle, baseline guid, region guid, assembly handle, subassembly handle) of the solid property sets | |||
(string corridor, string baseline, string region, string assembly, string subassembly)? solidKey = | |||
GetCorridorSolidIdFromPropertySet(solid, tr); | |||
(string, string, string, string, string)? solidKey = GetCorridorSolidIdFromPropertySet(solid, tr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made me blind, we should improve this
…s-for-corridor-subassemblies
Corridor solids were being attached to every applied subassembly.
This pr converts the assembly used for each region and attaches it in
elements
, as well as the subassemblies (which now contain the display meshes).Other changes:
Sample commit: https://latest.speckle.systems/projects/3f895e614f/models/2533bf268e