Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogukan/cnx 646 - Tekla Converter Project #328

Merged
merged 36 commits into from
Oct 28, 2024

Conversation

dogukankaratas
Copy link
Contributor

First POC to convert Tekla objects and send them to Speckle. Only converts Beam objects for now.

Copy link

linear bot commented Oct 25, 2024

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.39%. Comparing base (f7060c7) to head (4ac3e98).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #328   +/-   ##
=====================================
  Coverage   8.39%   8.39%           
=====================================
  Files        240     240           
  Lines       4835    4835           
  Branches     562     562           
=====================================
  Hits         406     406           
  Misses      4412    4412           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, barring some pending refactors once you get around to adding top-level converters

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!!

@oguzhankoral oguzhankoral enabled auto-merge (squash) October 28, 2024 19:49
@oguzhankoral oguzhankoral merged commit 5783b83 into dev Oct 28, 2024
3 checks passed
@oguzhankoral oguzhankoral deleted the dogukan/cnx-646-set-up-tekla-converter-project branch October 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants