-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dogukan/cnx 646 - Tekla Converter Project #328
Dogukan/cnx 646 - Tekla Converter Project #328
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #328 +/- ##
=====================================
Coverage 8.39% 8.39%
=====================================
Files 240 240
Lines 4835 4835
Branches 562 562
=====================================
Hits 406 406
Misses 4412 4412
Partials 17 17 ☔ View full report in Codecov by Sentry. |
…s://github.com/specklesystems/speckle-sharp-connectors into dogukan/cnx-646-set-up-tekla-converter-project
…s://github.com/specklesystems/speckle-sharp-connectors into dogukan/cnx-646-set-up-tekla-converter-project
…s://github.com/specklesystems/speckle-sharp-connectors into dogukan/cnx-646-set-up-tekla-converter-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, barring some pending refactors once you get around to adding top-level converters
Connectors/Tekla/Speckle.Connector.Tekla2024/Bindings/TeklaSendBinding.cs
Show resolved
Hide resolved
Converters/Tekla/Speckle.Converter.Tekla2024/ToSpeckle/Raw/BeamRawConverter.cs
Show resolved
Hide resolved
Converters/Tekla/Speckle.Converter.Tekla2024/ToSpeckle/TopLevel/BeamConverter.cs
Outdated
Show resolved
Hide resolved
Converters/Tekla/Speckle.Converter.Tekla2024/Speckle.Converter.Tekla2024.csproj
Outdated
Show resolved
Hide resolved
This reverts commit 94fa0a2.
…s://github.com/specklesystems/speckle-sharp-connectors into dogukan/cnx-646-set-up-tekla-converter-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor
Converters/Tekla/Speckle.Converter.Tekla2024/ToSpeckle/Raw/BeamRawConverter.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!!
First POC to convert Tekla objects and send them to Speckle. Only converts Beam objects for now.