Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revit): removes start angle and end angle reliance in revit arc converter #345

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

clairekuang
Copy link
Member

before:
image

after:
{7A95DF7F-51E2-4E17-9DF6-EF36278E2FBA}

Copy link

linear bot commented Nov 4, 2024

@clairekuang clairekuang enabled auto-merge (squash) November 4, 2024 11:59
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.40%. Comparing base (54ce865) to head (520b3fc).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...itShared/ToHost/Raw/Geometry/ArcConverterToHost.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #345      +/-   ##
========================================
+ Coverage   8.39%   8.40%   +0.01%     
========================================
  Files        240     240              
  Lines       4837    4829       -8     
  Branches     562     561       -1     
========================================
  Hits         406     406              
+ Misses      4414    4406       -8     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairekuang clairekuang merged commit 8cfe0bf into dev Nov 4, 2024
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-707-civil2revit-missing-curves branch November 4, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants