-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: Assign glossary terms with grouping keys to single-character groupings #12862
Open
jayaddison
wants to merge
7
commits into
sphinx-doc:master
Choose a base branch
from
jayaddison:issue-12707/genindex-glossary-grouping-keys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HTML: Assign glossary terms with grouping keys to single-character groupings #12862
jayaddison
wants to merge
7
commits into
sphinx-doc:master
from
jayaddison:issue-12707/genindex-glossary-grouping-keys
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ef7312b - Browse repository at this point
Copy the full SHA ef7312bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1334038 - Browse repository at this point
Copy the full SHA 1334038View commit details -
Glossary: derive index group from
category_key
This fixes a bug where previously the `category_key` -- an optional grouping that can be specified on glossary terms -- was used directly as the group name to place terms within in the generated HTML index. The fix re-uses a similar logic flow as used in `_key_func_1`, where the `category_key` is used to derive (but not as an absolute source of) the index group.
Configuration menu - View commit details
-
Copy full SHA for 4255bbe - Browse repository at this point
Copy the full SHA 4255bbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51aec85 - Browse repository at this point
Copy the full SHA 51aec85View commit details
Commits on Sep 5, 2024
-
Glossary: nest
category_key
items in indexThe grouping key (`category_key`) from glossary terms is used to decide what symbol/character to group the corresponding terms into. However: the terms are not guaranteed to begin with the same symbol as the `category_key`. This code therefore places them into a nested definition entry in the index, with the complete `category_key` as the parent label. Relates to commit 4255bbe.
Configuration menu - View commit details
-
Copy full SHA for 6a38601 - Browse repository at this point
Copy the full SHA 6a38601View commit details -
Configuration menu - View commit details
-
Copy full SHA for 295ee97 - Browse repository at this point
Copy the full SHA 295ee97View commit details -
Tests: fixup: use Python-supported XPath subset, and rename function
Relates-to commit 295ee97.
Configuration menu - View commit details
-
Copy full SHA for 2233c16 - Browse repository at this point
Copy the full SHA 2233c16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.