Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the PEP 735 [dependency-groups] table #13073

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AA-Turner
Copy link
Member

Comment on lines +94 to +99
all = [
{ include-group = "docs" },
{ include-group = "lint" },
{ include-group = "test" },
{ include-group = "types" },
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question: ought we use all, which seems more natural to me, or dev, which is special-cased by uv?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change tool.uv.default-groups to ["all"] if you want

@chrisjsewell
Copy link
Member

Heya @AA-Turner you would also need to change the tox config.

It does now support it in core tox-dev/tox#3409,
although I also want to make sure it works with https://github.com/tox-dev/tox-uv

@@ -35,7 +35,7 @@ jobs:
"https://astral.sh/uv/install.sh"
| sh
- name: Install dependencies
run: uv pip install .[docs]
run: uv pip install --group docs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the workflows seem to be failing with error: unexpected argument '--group' found -- uv may not have implemented support for dependency groups with the uv pip install command yet...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not appear to be yet supported by pip itself? pypa/pip#12963

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, for some reason I thought pip had already merged support. Let's leave this PR as draft until pip gets support, then.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we don't have support in the pip interface yet because it depends what pip does :)

@chrisjsewell
Copy link
Member

although I also want to make sure it works with tox-dev/tox-uv

tox-dev/tox-uv#114

@jayaddison jayaddison added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants