-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the PEP 735 [dependency-groups] table #13073
base: master
Are you sure you want to change the base?
Conversation
all = [ | ||
{ include-group = "docs" }, | ||
{ include-group = "lint" }, | ||
{ include-group = "test" }, | ||
{ include-group = "types" }, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question: ought we use all
, which seems more natural to me, or dev
, which is special-cased by uv
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change tool.uv.default-groups
to ["all"]
if you want
Heya @AA-Turner you would also need to change the tox config. It does now support it in core tox-dev/tox#3409, |
@@ -35,7 +35,7 @@ jobs: | |||
"https://astral.sh/uv/install.sh" | |||
| sh | |||
- name: Install dependencies | |||
run: uv pip install .[docs] | |||
run: uv pip install --group docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the workflows seem to be failing with error: unexpected argument '--group' found
-- uv
may not have implemented support for dependency groups with the uv pip install
command yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not appear to be yet supported by pip itself? pypa/pip#12963
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, for some reason I thought pip
had already merged support. Let's leave this PR as draft until pip
gets support, then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we don't have support in the pip interface yet because it depends what pip does :)
|
Per @zanieb in https://github.com/sphinx-doc/sphinx/pull/12817/files#r1817302168, this is now supported in
uv
.A