This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Add support for experimental flags #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Memon <[email protected]>
faisal-memon
requested review from
marcofranssen,
kfox1111,
dfeldman,
mrsabath and
edwbuck
as code owners
kfox1111
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Maybe a comment in the generated notes like:
https://github.com/spiffe/helm-charts/blob/main/charts/spire/templates/NOTES.txt#L6-L7
stating something like warning, experimental flags detected?
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
warning added |
Signed-off-by: Faisal Memon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the experimental section of the config. Needed for developers. This PR doesnt add support for the
auth_opa_policy_engineexperimental config.