Component filtering #197
Open
Component filtering #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-goldenring
requested review from
Mossaka,
jsturtevant,
radu-matei and
devigned
as code owners
Signed-off-by: Kate Goldenring <[email protected]>
kate-goldenring
force-pushed
the
component-filtering
branch
from
1006722
to
b9abe16
Compare
rylev
approved these changes
Oct 11, 2024
@rylev i agree that this is entirely duplicated code. I brought up this topic in the Spin PR but we punted not knowing the best place for it: fermyon/spin#2826 (comment). That being said, I'll look at moving it to a crate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin CLI added support for
spin up --component-id "foo" --component-id "bar"to run a subset of components of a Spin app in fermyon/spin#2826.This brings that functionality to the shim assuming that the components to support are supplied in
SPIN_COMPONENTS_TO_RETAINenvironment variable of a Pod as a comma separated list (SPIN_COMPONENTS_TO_RETAIN="foo,bar").In the Spin Operator, we can add a field to the SpinApp CR spec called
componentsthat lists which components of an app to retain in a pod.This is on top of @rylev's changes #189. The additive changes are in 1006722