feat(gce): support resource-manager-tags in GCE deployment #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not able to add tests as part of my changes because there is not an easy way to mock the BasicGoogleDeployHandler. I think we need to add testing to this cloud provider so I created the following issue to refactor the code: spinnaker/spinnaker#6985 |
link108
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support resourceManagerTags in GCE. See: https://cloud.google.com/compute/docs/reference/rest/v1/instanceTemplates/insert
Adds resourceManagerTags in the description operation and add it in the instanceTemplateProperties.
Issue related: spinnaker/spinnaker#6931
this PR replaced the previous PR in clouddriver because I want to leave only my changes related to
resource-manager-tags