-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gce): add support for hyperdisk in GCE #6288
Conversation
...-google/src/test/groovy/com/netflix/spinnaker/clouddriver/google/model/GoogleDiskSpec.groovy
Outdated
Show resolved
Hide resolved
...-google/src/test/groovy/com/netflix/spinnaker/clouddriver/google/model/GoogleDiskSpec.groovy
Outdated
Show resolved
Hide resolved
LGTM. I'd love someone who knows more about the google provider to have a look. |
Looks good, there is a gotcha with the hyperdisks that only specific instance families are supported but i guess a user requesting hyperdisk is aware of that. |
That is right, Hyperdisk is only supported in specific instance families. The right place to add a validation would be Deck but that is a nice-to-have thing because we assumed the user knows that hyperdisk is for critical instances. Even in the default instances provided by Spinnaker in GCE it doesn't have C3, C4 families to add validations. The users that will use hyperdisk is not configuring their instances using deck-ui. |
We add
hyperdisk-balanced
as an option for GCE deployment in Spinnaker. See: https://cloud.google.com/compute/docs/disks/hyperdisksGoogleDiskType has the available disk types that Spinnaker can deploy. By adding
hyperdisk-balanced
the instance templates in GCE can now use hyperdisk.