fix(ecs): Cloudwatch alarms cleanup on destroy ecs group #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christosarvanitis
force-pushed
the
fix-ecs-delete-alarms
branch
from
fdd97f0 to
2487e0d
Compare
jasonmcintosh
approved these changes
Dec 12, 2024
christosarvanitis
added a commit
to armory-io/clouddriver
that referenced
this pull request
Dec 12, 2024
|
@Mergifyio backport release-1.36.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit 3192885)
mergify bot
added a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit 3192885) Co-authored-by: Christos Arvanitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the PR #6256 the ECSCloudwatchAlarmCacheClient.getMetricAlarms was changed to accept the ecsClusterName. However a bug was introduced in the deleteMetrics where the getMetricAlarms was called with the wrong signature.